Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added Data Residency support #203

Merged
merged 20 commits into from Feb 1, 2023
Merged

feat: added Data Residency support #203

merged 20 commits into from Feb 1, 2023

Conversation

desusai7
Copy link
Contributor

@desusai7 desusai7 commented Oct 25, 2022 •
edited by SumanthPuram

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Version updated in README
  • Version updated in RSConstants.m(v1)/RSConstant.swift(v2)
  • Version updated in Rudder.xcodeproj
  • Version updated in Rudder.podspec
  • CHANGELOG Updated
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation
  • Passed pod lib lint --no-clean --allow-warnings

This change is Reviewable

@desusai7 desusai7 self-assigned this Oct 25, 2022
@desusai7 desusai7 added the Work in progress work in progress label Oct 25, 2022
@desusai7 desusai7 marked this pull request as ready for review October 26, 2022 11:31
@pallabmaiti pallabmaiti changed the base branch from master to develop October 26, 2022 15:10
pallabmaiti
pallabmaiti suggested changes Oct 26, 2022
View reviewed changes
Sources/Classes/Public/RSEnums.h Outdated Show resolved Hide resolved
pallabmaiti
pallabmaiti suggested changes Oct 28, 2022
View reviewed changes
Sources/Classes/RSConfig.m Outdated Show resolved Hide resolved
Sources/Classes/RSServerConfigManager.m Outdated Show resolved Hide resolved
@desusai7 desusai7 added Ready for review and removed Work in progress work in progress labels Oct 31, 2022
pallabmaiti
pallabmaiti previously approved these changes Oct 31, 2022
View reviewed changes
@pallabmaiti pallabmaiti changed the base branch from develop to master November 4, 2022 15:21
@pallabmaiti pallabmaiti dismissed their stale review November 4, 2022 15:21

The base branch was changed.

@pallabmaiti pallabmaiti changed the base branch from master to develop November 4, 2022 15:22
@pallabmaiti pallabmaiti changed the title feat: Data Residency Support feat: added Data Residency support Nov 7, 2022
pallabmaiti
pallabmaiti previously approved these changes Nov 7, 2022
View reviewed changes
pallabmaiti
pallabmaiti previously approved these changes Nov 10, 2022
View reviewed changes
pallabmaiti
pallabmaiti previously approved these changes Nov 16, 2022
View reviewed changes
@pallabmaiti
Copy link
Contributor

@desusai7 I can see 1 bug in Sonarcloud. Can you take care that?

@desusai7
Copy link
Contributor Author

@pallabmaiti fixed it now

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@1abhishekpandey 1abhishekpandey merged commit 3b2b933 into develop Feb 1, 2023
@1abhishekpandey 1abhishekpandey deleted the feat/dataResidency branch February 1, 2023 15:23
@devops-github-rudderstack devops-github-rudderstack mentioned this pull request Feb 2, 2023
Merged
This was referenced Feb 9, 2023
Closed
Merged
This was referenced Feb 28, 2023
Closed
Closed
@devops-github-rudderstack devops-github-rudderstack mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pallabmaiti pallabmaiti pallabmaiti approved these changes

@itsdebs itsdebs Awaiting requested review from itsdebs

Assignees

@desusai7 desusai7

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@desusai7 @pallabmaiti @1abhishekpandey