Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 staging --> v1.1 staging [IE support related changes (#449)] #451

Merged
merged 14 commits into from
Feb 11, 2022

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Feb 11, 2022

  • IE support related changes

  • logger.debug removed

  • code cleanup

  • set-value package replaced with simple logic

  • polyfill url added in constant

  • test case for camelcase logic

Co-authored-by: Moumita Mandal moumita@rudderstack.com

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

arnab-p and others added 10 commits January 20, 2022 21:00
* IE support related changes

* logger.debug removed

* code cleanup

* set-value package replaced with simple logic

* polyfill url added in constant

* test case for camelcase logic

Co-authored-by: Moumita Mandal <moumita@rudderstack.com>
* IE support related changes

* logger.debug removed

* code cleanup

* set-value package replaced with simple logic

* polyfill url added in constant

* test case for camelcase logic

Co-authored-by: Moumita Mandal <moumita@rudderstack.com>

Co-authored-by: Moumita Mandal <moumita@rudderstack.com>
@saikumarrs saikumarrs merged commit 9b414bf into perf_improvements Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants