fix: error reporting handling and config changes (#4195)

rudderlabs · Dec 5, 2023 · 70af46e · 70af46e
1 parent 79f8551
commit 70af46e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/enterprise/reporting/error_index/error_index_reporting.go b/enterprise/reporting/error_index/error_index_reporting.go
@@ -305,8 +305,11 @@ func (eir *ErrorIndexReporter) mainLoop(ctx context.Context, errIndexDB *jobsdb.
 }
 
 func (eir *ErrorIndexReporter) Stop() {
+	eir.log.Infow("stopping error index reporter")
 	eir.cancel()
-	_ = eir.g.Wait()
+	if err := eir.g.Wait(); err != nil {
+		eir.log.Errorw("stopped error index reporter with error", "error", err)
+	}
 }
 
 // resolveJobsDB returns the jobsdb that matches the current transaction (using system information functions)

diff --git a/enterprise/reporting/error_index/worker.go b/enterprise/reporting/error_index/worker.go
@@ -88,7 +88,7 @@ func newWorker(
 
 	w.config.parquetParallelWriters = conf.GetReloadableInt64Var(8, 1, "Reporting.errorIndexReporting.parquetParallelWriters")
 	w.config.parquetRowGroupSize = conf.GetReloadableInt64Var(512*bytesize.MB, 1, "Reporting.errorIndexReporting.parquetRowGroupSize")
-	w.config.parquetPageSize = conf.GetReloadableInt64Var(8*bytesize.KB, 1, "Reporting.errorIndexReporting.parquetPageSizeInKB")
+	w.config.parquetPageSize = conf.GetReloadableInt64Var(8*bytesize.KB, 1, "Reporting.errorIndexReporting.parquetPageSize")
 	w.config.instanceID = conf.GetString("INSTANCE_ID", "1")
 	w.config.bucketName = conf.GetString("ErrorIndex.Storage.Bucket", "rudder-failed-messages")
 	w.config.payloadLimit = conf.GetReloadableInt64Var(1*bytesize.GB, 1, "Reporting.errorIndexReporting.payloadLimit")