Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(warehouse): snowflake roles support. #3031

Merged
merged 8 commits into from
Feb 27, 2023
Merged

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Feb 23, 2023

Description

  • Added roles support for the Snowflake.
  • Enabled Snowflake Integration tests.
  • Added Snowflake Integration tests for Role-based access.
  • Deepsource recommendations
    • use %q instead of "%s" for quoted strings

Notion Ticket

https://www.notion.so/rudderstacks/Snowflake-support-for-roles-bc2f264c6f0d4fd28a585b3424e954bd?pvs=4

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 52.97% // Head: 52.98% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (32d0199) compared to base (ed83eaa).
Patch coverage: 8.21% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3031      +/-   ##
==========================================
+ Coverage   52.97%   52.98%   +0.01%     
==========================================
  Files         334      334              
  Lines       51863    51878      +15     
==========================================
+ Hits        27475    27489      +14     
- Misses      22785    22789       +4     
+ Partials     1603     1600       -3     
Impacted Files Coverage Δ
warehouse/integrations/testhelper/setup.go 0.00% <0.00%> (ø)
warehouse/integrations/snowflake/snowflake.go 1.34% <7.14%> (+0.39%) ⬆️
warehouse/integrations/manager/manager.go 52.85% <50.00%> (-0.09%) ⬇️
processor/worker.go 82.81% <0.00%> (-2.35%) ⬇️
jobsdb/migration.go 77.06% <0.00%> (+0.77%) ⬆️
services/rsources/handler.go 75.20% <0.00%> (+1.37%) ⬆️
config/backend-config/backend-config.go 83.33% <0.00%> (+1.58%) ⬆️
testhelper/log/log.go 11.53% <0.00%> (+3.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@lvrach lvrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add an integration test were role is used ?

Other than that looks good to me.

@achettyiitr
Copy link
Member Author

achettyiitr commented Feb 23, 2023

Shall we add an integration test were role is used ?

Other than that looks good to me.

Good point. Added role-base access Integration test as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants