-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(warehouse): snowflake roles support. #3031
Conversation
8ff4ab5
to
4b10c0b
Compare
Codecov ReportBase: 52.97% // Head: 52.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3031 +/- ##
==========================================
+ Coverage 52.97% 52.98% +0.01%
==========================================
Files 334 334
Lines 51863 51878 +15
==========================================
+ Hits 27475 27489 +14
- Misses 22785 22789 +4
+ Partials 1603 1600 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we add an integration test were role is used ?
Other than that looks good to me.
Good point. Added role-base access Integration test as well. |
Description
Notion Ticket
https://www.notion.so/rudderstacks/Snowflake-support-for-roles-bc2f264c6f0d4fd28a585b3424e954bd?pvs=4
Security