Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(warehouse): snowflake roles support. #3031

Merged
merged 8 commits into from
Feb 27, 2023
Merged

feat(warehouse): snowflake roles support. #3031

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cab7046
added role support for snowflake
achettyiitr Feb 23, 2023
4b10c0b
enable snowflake integration tests
achettyiitr Feb 23, 2023
03e2adc
deepsource changes
achettyiitr Feb 23, 2023
50038f2
Merge branch 'master' of github.com:rudderlabs/rudder-server into fea…
achettyiitr Feb 24, 2023
87316ed
add integration test for snowflake role
achettyiitr Feb 24, 2023
7770427
added snowflake role namespace
achettyiitr Feb 24, 2023
5adb5c0
added snowflake role integration tests
achettyiitr Feb 24, 2023
32d0199
sources template snowflake fix
achettyiitr Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions warehouse/integrations/manager/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,9 @@ func New(destType string) (Manager, error) {
var bq bigquery.HandleT
return &bq, nil
case warehouseutils.SNOWFLAKE:
var sf snowflake.HandleT
return &sf, nil
sf := snowflake.NewSnowflake()
snowflake.WithConfig(sf, config.Default)
return sf, nil
case warehouseutils.POSTGRES:
pg := postgres.NewHandle()
postgres.WithConfig(pg, config.Default)
Expand Down Expand Up @@ -105,8 +106,9 @@ func NewWarehouseOperations(destType string) (WarehouseOperations, error) {
var bq bigquery.HandleT
return &bq, nil
case warehouseutils.SNOWFLAKE:
var sf snowflake.HandleT
return &sf, nil
sf := snowflake.NewSnowflake()
snowflake.WithConfig(sf, config.Default)
return sf, nil
case warehouseutils.POSTGRES:
pg := postgres.NewHandle()
postgres.WithConfig(pg, config.Default)
Expand Down