Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clickhouse zookeeper table metadata #4121

Merged
merged 10 commits into from
Nov 17, 2023
Merged

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Nov 13, 2023

Description

The proposed change involves introducing a UUID to the storage path in Zookeeper in ClickHouse's cluster mode. This modification aims to address the issue where dropping and recreating a table takes 7-8 minutes for the metadata to be cleared. By adding a UUID to the storage path, the implementation ensures that such operations can be executed instantly, allowing data to be written to a different path in ZooKeeper. This enhancement improves the efficiency of table management in ClickHouse clusters.

Linear Ticket

Fixes PIPE-482

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c28e25) 72.36% compared to head (354ebce) 72.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4121      +/-   ##
==========================================
+ Coverage   72.36%   72.56%   +0.20%     
==========================================
  Files         382      382              
  Lines       55420    55420              
==========================================
+ Hits        40105    40217     +112     
+ Misses      12983    12884      -99     
+ Partials     2332     2319      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisse21 cisse21 force-pushed the fix.clickhouseClusterMetadata branch from e76b641 to 9db76f8 Compare November 15, 2023 10:11
@cisse21 cisse21 marked this pull request as ready for review November 15, 2023 12:25
@cisse21 cisse21 linked an issue Nov 15, 2023 that may be closed by this pull request
@cisse21 cisse21 force-pushed the fix.clickhouseClusterMetadata branch from 9e45f29 to 354ebce Compare November 17, 2023 05:04
@cisse21 cisse21 merged commit 41e060a into master Nov 17, 2023
40 checks passed
@cisse21 cisse21 deleted the fix.clickhouseClusterMetadata branch November 17, 2023 06:19
@redsquare
Copy link

yay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UUID to Clickhouse table definition for zookeeper path
5 participants