Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickhouse changes #1300

Merged
merged 126 commits into from
Oct 8, 2021
Merged

Clickhouse changes #1300

merged 126 commits into from
Oct 8, 2021

Conversation

achettyiitr
Copy link
Member

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

@codecov
Copy link

codecov bot commented Oct 3, 2021

Codecov Report

Merging #1300 (fa895ed) into master (551d23d) will decrease coverage by 0.11%.
The diff coverage is 21.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1300      +/-   ##
==========================================
- Coverage   22.58%   22.46%   -0.12%     
==========================================
  Files         115      116       +1     
  Lines       21668    22138     +470     
==========================================
+ Hits         4893     4973      +80     
- Misses      16463    16849     +386     
- Partials      312      316       +4     
Impacted Files Coverage Δ
app/features.go 0.00% <ø> (ø)
event-schema/event_schema.go 0.00% <0.00%> (ø)
gateway/gateway.go 47.94% <0.00%> (-2.53%) ⬇️
processor/transformer/transformer.go 0.00% <ø> (ø)
router/failed-events-manager.go 0.00% <0.00%> (ø)
services/filemanager/digitalOceanSpacesManager.go 0.00% <0.00%> (ø)
services/filemanager/gcsmanager.go 0.00% <0.00%> (ø)
services/filemanager/miniomanager.go 0.00% <0.00%> (ø)
services/validators/envValidator.go 1.58% <0.00%> (-0.03%) ⬇️
utils/misc/misc.go 0.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d6ebb8...fa895ed. Read the comment docs.

@achettyiitr achettyiitr added Ready for Review and removed WIP work in progress labels Oct 4, 2021
warehouse/warehouse.go Show resolved Hide resolved
warehouse/warehouse.go Outdated Show resolved Hide resolved
warehouse/warehouse.go Outdated Show resolved Hide resolved
warehouse/warehouse.go Outdated Show resolved Hide resolved
warehouse/warehouse.go Show resolved Hide resolved
warehouse/warehouse.go Show resolved Hide resolved
warehouse/warehouse.go Outdated Show resolved Hide resolved
warehouse/warehouse.go Outdated Show resolved Hide resolved
@psrikanth88 psrikanth88 merged commit 3cc7a71 into master Oct 8, 2021
@github-actions github-actions bot deleted the clickhouse_changes branch May 28, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants