Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use gauge for capturing pending events #2960

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Conversation

lvrach
Copy link
Member

@lvrach lvrach commented Feb 9, 2023

Description

Count was the incorrect metric type to capture the number of pending events. Since we were interested in the time value and not the rate of change.

Notion Ticket

https://www.notion.so/rudderstacks/Reduce-alert-noise-Improve-observability-5beff5b1a6e34a92a071b37ab117bf45?pvs=4

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 52.02% // Head: 51.99% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (1ed2403) compared to base (f20a6f3).
Patch coverage: 6.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2960      +/-   ##
==========================================
- Coverage   52.02%   51.99%   -0.04%     
==========================================
  Files         324      324              
  Lines       51231    51284      +53     
==========================================
+ Hits        26654    26665      +11     
- Misses      22966    23010      +44     
+ Partials     1611     1609       -2     
Impacted Files Coverage Δ
warehouse/client/controlplane/client.go 34.48% <0.00%> (-26.75%) ⬇️
warehouse/validations/validate.go 51.60% <0.00%> (-2.31%) ⬇️
gateway/webhook/webhook.go 53.70% <66.66%> (+0.11%) ⬆️
warehouse/warehouse.go 11.54% <100.00%> (ø)
router/router.go 76.89% <0.00%> (+0.18%) ⬆️
config/backend-config/namespace_config.go 70.00% <0.00%> (+3.00%) ⬆️
router/manager/manager.go 100.00% <0.00%> (+3.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lvrach lvrach marked this pull request as ready for review February 9, 2023 14:31
@Jayachand Jayachand merged commit 169ab96 into master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants