chore: uploads cleanup #3743
Merged
chore: uploads cleanup #3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achettyiitr
force-pushed
the
chore.upload-job-cleanup
branch
from
d2133ce
to
6b03d1c
Compare
achettyiitr
force-pushed
the
chore.upload-job-cleanup
branch
from
6b03d1c
to
5402e72
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3743 +/- ##
==========================================
- Coverage 68.78% 68.66% -0.12%
==========================================
Files 345 346 +1
Lines 51917 51939 +22
==========================================
- Hits 35711 35666 -45
- Misses 13907 13970 +63
- Partials 2299 2303 +4
☔ View full report in Codecov by Sentry. |
lvrach
approved these changes
Aug 17, 2023
fracasula
approved these changes
Aug 18, 2023
warehouse/upload_stats_test.go
Outdated
Comment on lines
31
to
49
| pool, err := dockertest.NewPool("") | ||
| require.NoError(t, err) | ||
|
|
||
| pgResource, err := resource.SetupPostgres(pool, t) | ||
| require.NoError(t, err) | ||
|
|
||
| t.Log("db:", pgResource.DBDsn) | ||
|
|
||
| err = (&migrator.Migrator{ | ||
| Handle: pgResource.DB, | ||
| MigrationsTable: "wh_schema_migrations", | ||
| }).Migrate("warehouse") | ||
| require.NoError(t, err) | ||
|
|
||
| sqlStatement, err := os.ReadFile("testdata/sql/stats_test.sql") | ||
| require.NoError(t, err) | ||
|
|
||
| _, err = pgResource.DB.Exec(string(sqlStatement)) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
We could remove some duplicated code in these tests by using a common setup function:
func setupUploadTest(t testing.TB, migrationsPath string) *sql.DB {
pool, err := dockertest.NewPool("")
require.NoError(t, err)
pgResource, err := resource.SetupPostgres(pool, t)
require.NoError(t, err)
t.Log("db:", pgResource.DBDsn)
err = (&migrator.Migrator{
Handle: pgResource.DB,
MigrationsTable: "wh_schema_migrations",
}).Migrate("warehouse")
require.NoError(t, err)
sqlStatement, err := os.ReadFile(migrationsPath)
require.NoError(t, err)
_, err = pgResource.DB.Exec(string(sqlStatement))
require.NoError(t, err)
return pgResource.DB
}
1 task
Closed
This was referenced Aug 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linear Ticket
Security