Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: splitting warehouse package #3828

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Sep 4, 2023

Description

  • Splitting warehouse packages into smaller packages. (admin, api, backend_config, constraints, errors, mode, router, slave, types)

Linear Ticket

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr force-pushed the chore.warehouse-separate-packages branch from 2dbda7b to 166239a Compare September 4, 2023 23:31
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 89.59% and project coverage change: -0.05% ⚠️

Comparison is base (43b645b) 69.31% compared to head (c3f96b1) 69.26%.

Additional details and impacted files
@@                        Coverage Diff                        @@
##           chore.introduce-warehouse-app    #3828      +/-   ##
=================================================================
- Coverage                          69.31%   69.26%   -0.05%     
=================================================================
  Files                                354      355       +1     
  Lines                              52594    52650      +56     
=================================================================
+ Hits                               36454    36469      +15     
- Misses                             13824    13871      +47     
+ Partials                            2316     2310       -6     
Files Changed Coverage Δ
warehouse/api/grpc.go 79.86% <ø> (ø)
warehouse/errors/errors.go 100.00% <ø> (ø)
warehouse/router/upload_stats.go 62.33% <ø> (ø)
warehouse/types/types.go 70.00% <ø> (ø)
warehouse/router/identities.go 19.83% <11.11%> (ø)
router/batchrouter/handle_observability.go 58.62% <50.00%> (ø)
warehouse/admin/admin.go 7.14% <50.00%> (ø)
warehouse/router/scheduling.go 95.23% <50.00%> (ø)
warehouse/bcm/bcm.go 82.32% <58.33%> (ø)
warehouse/schema/schema.go 96.00% <92.59%> (ø)
... and 11 more

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr
Copy link
Member Author

achettyiitr commented Sep 11, 2023

Currently, it depends on #3773, Since schema will create circular dependency w.r.t warehouse and router package.

@achettyiitr achettyiitr deleted the chore.warehouse-separate-packages branch September 22, 2023 21:21
@achettyiitr achettyiitr restored the chore.warehouse-separate-packages branch September 22, 2023 21:21
@github-actions github-actions bot deleted the chore.warehouse-separate-packages branch November 11, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants