-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: warehouse tests race detection #3773
Conversation
PIPE-119 Run Warehouse tests with -race
We should change our continous integration pipeline to run the warehouse tests with Any data race detected is going to make the tests fail even if all assertions pass so resulting races should be eliminated as well. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3773 +/- ##
==========================================
+ Coverage 68.98% 69.02% +0.03%
==========================================
Files 348 349 +1
Lines 51834 51886 +52
==========================================
+ Hits 35760 35815 +55
+ Misses 13772 13770 -2
+ Partials 2302 2301 -1
☔ View full report in Codecov by Sentry. |
@@ -293,8 +293,6 @@ func TestIntegration(t *testing.T) { | |||
tc := tc | |||
|
|||
t.Run(tc.name, func(t *testing.T) { | |||
t.Parallel() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will go away anyway due to this PR.
fd67a61
to
81acc08
Compare
1dd8629
to
172b4f1
Compare
This reverts commit ce2ed33.
Description
Running warehouse tests with
-race
.Changelog
-race
in order to be able to detect bugs due unregulated concurrent access to the same variable(s)model.Schema
because even if we use a mutex to protect the concurrent access, we're still passing around a reference so a change to the map would still count as a data raceSchema
into its own package that now has both a public and a private APIuploadSchema
intoUploadJob
handleSchemaChange
and its errors toslave_worker
since it's specific to that business logicLinear Ticket
< Linear Link >
Security