feat: new event type - record #3879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koladilip
reviewed
Sep 26, 2023
| @@ -16,6 +16,7 @@ const ( | |||
| delimiter = "<<>>" | |||
| eventStreamSourceCategory = "eventStream" | |||
| extractEvent = "extract" | |||
| rETLEvent = "record" | |||
There was a problem hiding this comment.
can record format be used by server side sdks too or do we want to restrict only to rETL?
There was a problem hiding this comment.
I would say rETL. Don't see how would it be useful for server side sdks.
chandumlg
force-pushed
the
feat.eventype-record
branch
from
a087428
to
7388e2e
Compare
chandumlg
force-pushed
the
feat.eventype-record
branch
from
a0da929
to
29acfab
Compare
achettyiitr
approved these changes
Nov 6, 2023
atzoum
reviewed
Nov 6, 2023
chandumlg
force-pushed
the
feat.eventype-record
branch
from
cbdacab
to
be2e1d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3879 +/- ##
==========================================
- Coverage 71.98% 71.88% -0.11%
==========================================
Files 372 373 +1
Lines 54831 54834 +3
==========================================
- Hits 39472 39416 -56
- Misses 13059 13103 +44
- Partials 2300 2315 +15
☔ View full report in Codecov by Sentry. |
atzoum
approved these changes
Nov 8, 2023
1 task
This was referenced Nov 12, 2023
Closed
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New event type "record". (To be used to sync rETL records.)
Linear Ticket
https://linear.app/rudderstack/issue/INT-650/handling-new-event-type-processing-in-pipeline
Security