feat: new error types for destinations (snapchat_custom_audience, snapchat_conversion, slack, singular, signl4) #1655

mihir-4116 · 2022-12-13T05:17:04Z

Description of the change

Description here

Type of change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

Lint rules pass locally
The code changed/added as part of this pull request has been covered with tests
All tests related to the changed code pass in development

Code review

This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
"Ready for review" label attached to the PR and reviewers mentioned in a comment
Changes have been reviewed by at least one other engineer
Issue from task tracker has a link to this pull request

koladilip · 2022-12-13T05:34:58Z

src/v0/destinations/singular/util.js

@@ -106,7 +109,7 @@ const platformWisePayloadGenerator = (message, isSessionEvent) => {
  let platform = getValueFromMessage(message, "context.os.name");
  const typeOfEvent = isSessionEvent ? "SESSION" : "EVENT";
  if (!platform) {
-    throw new CustomError("[Singular] :: Platform name is missing", 400);
+    throw new InstrumentationError("Platform name is missing", 400);


error status is not required right

koladilip · 2022-12-13T05:35:30Z

src/v0/destinations/slack/transform.js

@@ -179,7 +179,7 @@ function processTrack(message, destination) {
  const eventTemplateConfig = destination.Config.eventTemplateSettings;

  if (!message.event) {
-    throw new CustomError("Event name is required", 400);
+    throw new InstrumentationError("Event name is required", 400);


error status is not required right

utsabc · 2022-12-13T05:53:42Z

src/v0/destinations/signl4/transform.js

  }
  if (!destination.Config.apiKey) {
-    throw new CustomError("apiKey is a required field", 400);
+    throw new ConfigurationError("apiKey is a required field");


Suggested change

throw new ConfigurationError("apiKey is a required field");

throw new ConfigurationError("ApiKey is a required field");

utsabc · 2022-12-13T05:55:20Z

src/v0/destinations/singular/transform.js

-      "[Singular]::event name is not present for the event",
-      400
-    );
+    throw new InstrumentationError("event name is not present for the event");


Suggested change

throw new InstrumentationError("event name is not present for the event");

throw new InstrumentationError("Event name is not present for the event");

utsabc · 2022-12-13T06:21:39Z

src/v0/destinations/singular/util.js

@@ -115,7 +118,7 @@ const platformWisePayloadGenerator = (message, isSessionEvent) => {
  }
  platform = platform.toLowerCase();
  if (!SUPPORTED_PLATFORM[platform]) {
-    throw new CustomError("[Singular] :: Platform is not supported");
+    throw new InstrumentationError("Platform is not supported");


Suggested change

throw new InstrumentationError("Platform is not supported");

throw new InstrumentationError(`Platform ${platform} is not supported`);

utsabc · 2022-12-13T06:22:18Z

src/v0/destinations/singular/util.js

@@ -106,7 +109,7 @@ const platformWisePayloadGenerator = (message, isSessionEvent) => {
  let platform = getValueFromMessage(message, "context.os.name");
  const typeOfEvent = isSessionEvent ? "SESSION" : "EVENT";
  if (!platform) {
-    throw new CustomError("[Singular] :: Platform name is missing", 400);
+    throw new InstrumentationError("Platform name is missing");


Suggested change

throw new InstrumentationError("Platform name is missing");

throw new InstrumentationError("Platform name is missing from context.os.name");

utsabc · 2022-12-13T06:30:51Z

src/v0/destinations/snapchat_conversion/transform.js

-    throw new CustomError(
-      "[Snapchat] :: Pixel Id is required for web and offline events",
-      400
+    throw new InstrumentationError(


This should be configuration error

utsabc · 2022-12-13T06:31:18Z

src/v0/destinations/snapchat_conversion/transform.js

-        "[Snapchat] :: App Id is required for app events",
-        400
-      );
+      throw new InstrumentationError("App Id is required for app events");


configuration error

utsabc · 2022-12-13T06:31:28Z

src/v0/destinations/snapchat_conversion/transform.js

-        "[Snapchat] :: Snap App Id is required for app events",
-        400
-      );
+      throw new InstrumentationError("Snap App Id is required for app events");


utsabc · 2022-12-13T06:44:42Z

src/v0/destinations/snapchat_custom_audience/transform.js

@@ -100,7 +99,7 @@ const getHashedProperty = (schema, hashedProperty) => {
    case "mobileAdId":
      return sha256(hashedProperty.toLowerCase());
    default:
-      throw new CustomError("Invalid schema", 400);
+      throw new InstrumentationError("Invalid schema");


Config error

utsabc · 2022-12-13T06:45:05Z

src/v0/destinations/snapchat_custom_audience/transform.js

@@ -80,7 +79,7 @@ const getProperty = (schema, element) => {
        element?.MOBILE_ID;
      return property;
    default:
-      throw new CustomError("Invalid schema", 400);
+      throw new InstrumentationError("Invalid schema");


Config error

utsabc · 2022-12-13T06:46:21Z

src/v0/destinations/snapchat_custom_audience/utils.js

-      )
-      .setStatus(400)
-      .build();
+    throw new InstrumentationError(


Configuration error

src/v0/destinations/snapchat_custom_audience/utils.js

* feat: introduce new tags and error classes * refactor: rename function as per latest implementation * refactor: replace ErrorBuilder with error type * fix: removed the ability to set stat tags externally in specific error types * feat: add destination and source ID tags * refactor: rename DefaultError to BaseError * fix: allow only error type and meta tags to be set in NetworkError class * fix: typo * refactor: replace with new error classes in GAOC destination * fix: remove error handling in proxy.test.js * fix: remove older stats and error types * chore(core): add internal code documentation Co-authored-by: Krishna Chaitanya <chaithu.kitti@gmail.com> * feat: revamp cdk V2 error handling (#1647) * feat: revamp cdk V2 error handling * fix: revert previously committed unwanted files * refactor: replace all references of CustomError in core (#1644) * fix: do not export CustomError * refactor: remove deprecated modules * refactor: replace all instances of CustomError in the core module * test: fix generic proxy test suite failures (#1656) * refactor: use new error types (#1658) * refactor: use new error types * fix: use the right error type * Revert "fix: use the right error type" This reverts commit 2887f3a. * feat: refactor new error types (ga360, gainsight, gainsight_px, google_cloud_function, googlepubsnub) (#1665) * feat:[ga360] add new errorTypes * feat:[google_cloud_function] add new errorTypes * feat:[googlepubsnub] add new errorTypes * feat:[gainsight_px] add new errorTypes * feat:[gainsight] add new errorTypes * feat: refactor new error types (awin, blueshift, bqstream, branch, braze) (#1649) * feat:[awin] add new error types * feat:[blueshift] add new error types * feat:[bqstream] add new error types * feat:[branch] add new error types * feat:[braze] add new error types * feat: refactor new error types (facebook_offline_conversions, facebook_pixel, factorsai, fb, fb_custom_audience) (#1652) * feat:[facebook_offline_conversions] add new errorTypes * feat:[facebook_pixel] add new errorTypes * feat:[factorsai] add new errorTypes * feat:[factorsai] add new errorTypes * feat:[fb] add new errorTypes * feat:[fb_custom_audience] add new errorTypes * fix: refactor error message and unit tests * feat: update error message * feat: refactor new error types (custify, customerio, delighted, engage, eventbridge) (#1651) * feat:[custify] add new error types * feat:[customerio] add new error types * feat:[customerio] add statTags in processRouterDest * feat:[delighted] add new errorTypes * feat:[engage] add new errorTypes * feat:[eventbridge] add new errorTypes * feat: new error types for destinations(mailmodo, mailchimp, lytics, leanplum, lambda) (#1669) * feat: new error types for destinations * feat: code review changes * feat: update new error types (#1673) * feat: new error types for user.com destination (#1638) * feat: new error types for user.com destination * feat: code review changes * feat: new error types for sources (appcenter, appsflyer, braze, canny) (#1641) * feat: new error types for sources * feat: code review changes * feat: new error types for destinations (trengo, userlist, variance, vero, webengage) (#1653) * feat: new error types for destinations * feat: code review changes * feat: code review changes * feat: new error types for destinations (#1661) * feat: new error types for destinations(persistiq, pardot, one_signal, ometria, mssql) (#1666) * feat: code review changes * feat: code review changes * feat: code review changes * feat: new error types for destinations(mixpanel, monetate, monday, moengage, minio) (#1667) * feat: new error types for destinations * feat: code review changes * feat: new error types for destinations(kustomer, kochava, klaviyo, kissmetrics, keen) (#1671) * feat: new error types for destinations * feat: code review changes * feat: new error types for destinations (rockerbox, revenue_cat, redis, refiner) (#1659) * feat: new error types for destinations * feat: code review changes * feat: new error types for destinations (tiktok_ads, statsig, splitio, snowflake) (#1654) * feat: new error types for destinations * feat: code review changes * feat: new error types for destinations (snapchat_custom_audience, snapchat_conversion, slack, singular, signl4) (#1655) * feat: new error types for destinations * feat: code review changes * feat: code review changes * feat: code review changes * feat: code review changes * feat: refactor new error types (google_adwords_enhanced_conversion, google_adwords_offline_conversion, google_adwords_remarketing_lists, heap, googlesheets (#1670) * feat:[google_adwords_enhanced_conversions] update new error types * feat:[google_adwords_remarketing_lists] update new error types * feat:[googlesheets] update new error types * feat:[google_adwords_offline_conversion] update new error types * feat:[heap] update new error types * feat: update new error types * feat: new error types for destinations(shynet, sfmc, serenytics, sendgrid, segment) (#1657) * feat: new error types for destinationss * feat: code review changes * feat: code review changes * feat: refactor new error types (hs, indicative, itercom, iterable, drip) (#1672) * feat:[HS] update new error types * feat:[indicative] update new error types * feat:[indicative] update new error types * feat:[intercom] update new error types * feat:[iterable] update new error types * feat:update new error types * feat:[drip] update new error types * feat: update new error types * feat: update new error types * feat: new error types for sources (gainsightpx, iterable, mailmodo, monday, shopify) (#1642) * feat: new error types for sources * feat: code review changes * feat: new error types for destinations (webhook, wootric, woopra, yahoo_dsp, zendesk) (#1645) * feat: new error types for destinations * feat: code review changes * feat: code review changes * feat: code review changes * feat: refactor new error types (campaign_manager, candu, canny, clevertap, confluent_cloud) (#1650) * feat:[campaign_manager] add new error types * feat:[candu] add new error types * feat:[canny] add new error types * feat:[clevertap] add new error types * feat:[confluent_cloud] add new error types * feat: add new errorTypes * feat: update new error types * feat: add new error types ( active_campaign, adjust, adobe_analytics, appsflyer, airship) (#1639) * feat:[active_campaign] add new error types * feat:[adj] add new error types * feat:[adobe_analytics] add new error types * feat:[appsFlyer] add new error types * feat:[airship] add new error types * feat:[active_campaign] update new error type for axios calls * feat: update new error types * feat: update new error types * feat: update new error types * feat: update new error types * feat: new error types for destinations(marketo, marketo_static_list, marketo_bulk_upload) (#1674) * feat: new error types for destinations * feat: code review changes * feat: code review changes * feat: code review changes * feat: code review changes * feat: code review changes * feat: add new errorTypes (firehose, freshsales, freshmarketer, ga, ga4) (#1660) * feat: add new errorTypes * feat: update new error types * feat: update new error types * feat: update new error types * feat: refactor new error types ( amplitude, algolia, appcues, attentive_tag, attribution, autopilot) (#1648) * feat:[algolia] add new error types * feat:[appcues] add new error types * feat: add new error types * feat: add new error types * feat:[autopilot] add new error types * feat: add new error types * feat: update new error types * feat: update new error types * fix: heap test cases (#1675) * feat: refactor-dcm_floodlight-cdk-errorTypes (#1677) * feat: refactor-dcm_floodlight-cdk-errorTypes * fix: june tests * fix: proxy test cases (#1678) * fix: proxy test cases * fix: code review changes * fix: code review changes * feat: refactor router transform implementation (#1676) * feat: revamped router transform logic * fix: revert previously committed unwanted files * fix: replace flowtype with feature * refactor: use default error message * fix: return response * refactor: extract redundant code to a utility method * chore: refactor all instances of previous error types (#1680) * refactor: replace final instances of old error types with new error types * fix: typo * fix: revert previously committed file * refactor: remove unwanted comments * fix: user deletion test cases (#1682) * fix: pinterest and algolia cdk test cases (#1681) * fix: pinterest cdk test cases * fix: code review changes * fix: code review changes * fix: code review changes * feat: router tranform refacor for destinations (batch - 1) (#1684) * feat: router tranform refacor * feat: router tranform refacor * feat: code review changes * feat: code review changes * feat: router tranform refacor (#1685) * feat: router tranform refacor for destinations (batch - 3) (#1686) * feat: router tranform refacor * feat: router tranform refactor * feat: code review changes * feat: refactor router transformer - 1 (#1687) * feat: refactor-processRouterDest * feat: refactor-processRouterDest * feat: refactor-processRouterDest (#1688) * feat: refactor-processRouterDest (#1689) * feat: refactor router transformer - 4 (#1690) * feat: refactor-processRouterDest * feat: refactor-processRouterDest * fix: incorrect usages of error types (#1691) * fix: remove all usages of TRANSFORMER_METRIC * fixcorrect usages of error types * feat: add assertConfig default binding * chore: remove unwanted arguments from function definition * chore: remove unwanted null * chore: simplified the syntax * fix: set default status code * chore: use optional chaining syntax * fix: remove unwanted status code argument * feat: destType removed (#1692) * feat: refactor error types - review comments (#1697) * fix: refactor error types * fix: rt workflow to send stat tags in pinterest tag * fix: router transform issues in marketo_static_list * fix: restore router transform implementation * fix: issues in router transformation across destinations Co-authored-by: saikumarrs <saibattinoju@rudderstack.com> * fix: final review issues (#1699) * chore: add workspaceId as stat-tag (#1700) Co-authored-by: Sai Sankeerth <sanpj2292@github.com> * feat: add error handling for CDK v1 (#1698) * fix: add parsed response in network error (#1704) * fix[gaec]: revert destination response * fix: authErrorCategory field in the response Co-authored-by: saikumarrs <saibattinoju@rudderstack.com> * fix: destinations network error responses (#1705) * refactor: error handler for user deletion Co-authored-by: Krishna Chaitanya <chaithu.kitti@gmail.com> Co-authored-by: Ujjwal Abhishek <63387036+ujjwal-ab@users.noreply.github.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: Sankeerth <sankeerth@rudderstack.com> Co-authored-by: Sai Sankeerth <sanpj2292@github.com>

* feat: introduce new tags and error classes * refactor: rename function as per latest implementation * refactor: replace ErrorBuilder with error type * fix: removed the ability to set stat tags externally in specific error types * feat: add destination and source ID tags * refactor: rename DefaultError to BaseError * fix: allow only error type and meta tags to be set in NetworkError class * fix: typo * refactor: replace with new error classes in GAOC destination * fix: remove error handling in proxy.test.js * fix: remove older stats and error types * chore(core): add internal code documentation Co-authored-by: Krishna Chaitanya <chaithu.kitti@gmail.com> * feat: revamp cdk V2 error handling (#1647) * feat: revamp cdk V2 error handling * fix: revert previously committed unwanted files * refactor: replace all references of CustomError in core (#1644) * fix: do not export CustomError * refactor: remove deprecated modules * refactor: replace all instances of CustomError in the core module * test: fix generic proxy test suite failures (#1656) * refactor: use new error types (#1658) * refactor: use new error types * fix: use the right error type * Revert "fix: use the right error type" This reverts commit 2887f3a. * feat: refactor new error types (ga360, gainsight, gainsight_px, google_cloud_function, googlepubsnub) (#1665) * feat:[ga360] add new errorTypes * feat:[google_cloud_function] add new errorTypes * feat:[googlepubsnub] add new errorTypes * feat:[gainsight_px] add new errorTypes * feat:[gainsight] add new errorTypes * feat: refactor new error types (awin, blueshift, bqstream, branch, braze) (#1649) * feat:[awin] add new error types * feat:[blueshift] add new error types * feat:[bqstream] add new error types * feat:[branch] add new error types * feat:[braze] add new error types * feat: refactor new error types (facebook_offline_conversions, facebook_pixel, factorsai, fb, fb_custom_audience) (#1652) * feat:[facebook_offline_conversions] add new errorTypes * feat:[facebook_pixel] add new errorTypes * feat:[factorsai] add new errorTypes * feat:[factorsai] add new errorTypes * feat:[fb] add new errorTypes * feat:[fb_custom_audience] add new errorTypes * fix: refactor error message and unit tests * feat: update error message * feat: refactor new error types (custify, customerio, delighted, engage, eventbridge) (#1651) * feat:[custify] add new error types * feat:[customerio] add new error types * feat:[customerio] add statTags in processRouterDest * feat:[delighted] add new errorTypes * feat:[engage] add new errorTypes * feat:[eventbridge] add new errorTypes * feat: new error types for destinations(mailmodo, mailchimp, lytics, leanplum, lambda) (#1669) * feat: new error types for destinations * feat: code review changes * feat: update new error types (#1673) * feat: new error types for user.com destination (#1638) * feat: new error types for user.com destination * feat: code review changes * feat: new error types for sources (appcenter, appsflyer, braze, canny) (#1641) * feat: new error types for sources * feat: code review changes * feat: new error types for destinations (trengo, userlist, variance, vero, webengage) (#1653) * feat: new error types for destinations * feat: code review changes * feat: code review changes * feat: new error types for destinations (#1661) * feat: new error types for destinations(persistiq, pardot, one_signal, ometria, mssql) (#1666) * feat: code review changes * feat: code review changes * feat: code review changes * feat: new error types for destinations(mixpanel, monetate, monday, moengage, minio) (#1667) * feat: new error types for destinations * feat: code review changes * feat: new error types for destinations(kustomer, kochava, klaviyo, kissmetrics, keen) (#1671) * feat: new error types for destinations * feat: code review changes * feat: new error types for destinations (rockerbox, revenue_cat, redis, refiner) (#1659) * feat: new error types for destinations * feat: code review changes * feat: new error types for destinations (tiktok_ads, statsig, splitio, snowflake) (#1654) * feat: new error types for destinations * feat: code review changes * feat: new error types for destinations (snapchat_custom_audience, snapchat_conversion, slack, singular, signl4) (#1655) * feat: new error types for destinations * feat: code review changes * feat: code review changes * feat: code review changes * feat: code review changes * feat: refactor new error types (google_adwords_enhanced_conversion, google_adwords_offline_conversion, google_adwords_remarketing_lists, heap, googlesheets (#1670) * feat:[google_adwords_enhanced_conversions] update new error types * feat:[google_adwords_remarketing_lists] update new error types * feat:[googlesheets] update new error types * feat:[google_adwords_offline_conversion] update new error types * feat:[heap] update new error types * feat: update new error types * feat: new error types for destinations(shynet, sfmc, serenytics, sendgrid, segment) (#1657) * feat: new error types for destinationss * feat: code review changes * feat: code review changes * feat: refactor new error types (hs, indicative, itercom, iterable, drip) (#1672) * feat:[HS] update new error types * feat:[indicative] update new error types * feat:[indicative] update new error types * feat:[intercom] update new error types * feat:[iterable] update new error types * feat:update new error types * feat:[drip] update new error types * feat: update new error types * feat: update new error types * feat: new error types for sources (gainsightpx, iterable, mailmodo, monday, shopify) (#1642) * feat: new error types for sources * feat: code review changes * feat: new error types for destinations (webhook, wootric, woopra, yahoo_dsp, zendesk) (#1645) * feat: new error types for destinations * feat: code review changes * feat: code review changes * feat: code review changes * feat: refactor new error types (campaign_manager, candu, canny, clevertap, confluent_cloud) (#1650) * feat:[campaign_manager] add new error types * feat:[candu] add new error types * feat:[canny] add new error types * feat:[clevertap] add new error types * feat:[confluent_cloud] add new error types * feat: add new errorTypes * feat: update new error types * feat: add new error types ( active_campaign, adjust, adobe_analytics, appsflyer, airship) (#1639) * feat:[active_campaign] add new error types * feat:[adj] add new error types * feat:[adobe_analytics] add new error types * feat:[appsFlyer] add new error types * feat:[airship] add new error types * feat:[active_campaign] update new error type for axios calls * feat: update new error types * feat: update new error types * feat: update new error types * feat: update new error types * feat: new error types for destinations(marketo, marketo_static_list, marketo_bulk_upload) (#1674) * feat: new error types for destinations * feat: code review changes * feat: code review changes * feat: code review changes * feat: code review changes * feat: code review changes * feat: add new errorTypes (firehose, freshsales, freshmarketer, ga, ga4) (#1660) * feat: add new errorTypes * feat: update new error types * feat: update new error types * feat: update new error types * feat: refactor new error types ( amplitude, algolia, appcues, attentive_tag, attribution, autopilot) (#1648) * feat:[algolia] add new error types * feat:[appcues] add new error types * feat: add new error types * feat: add new error types * feat:[autopilot] add new error types * feat: add new error types * feat: update new error types * feat: update new error types * fix: heap test cases (#1675) * feat: refactor-dcm_floodlight-cdk-errorTypes (#1677) * feat: refactor-dcm_floodlight-cdk-errorTypes * fix: june tests * fix: proxy test cases (#1678) * fix: proxy test cases * fix: code review changes * fix: code review changes * feat: refactor router transform implementation (#1676) * feat: revamped router transform logic * fix: revert previously committed unwanted files * fix: replace flowtype with feature * refactor: use default error message * fix: return response * refactor: extract redundant code to a utility method * chore: refactor all instances of previous error types (#1680) * refactor: replace final instances of old error types with new error types * fix: typo * fix: revert previously committed file * refactor: remove unwanted comments * fix: user deletion test cases (#1682) * fix: pinterest and algolia cdk test cases (#1681) * fix: pinterest cdk test cases * fix: code review changes * fix: code review changes * fix: code review changes * feat: router tranform refacor for destinations (batch - 1) (#1684) * feat: router tranform refacor * feat: router tranform refacor * feat: code review changes * feat: code review changes * feat: router tranform refacor (#1685) * feat: router tranform refacor for destinations (batch - 3) (#1686) * feat: router tranform refacor * feat: router tranform refactor * feat: code review changes * feat: refactor router transformer - 1 (#1687) * feat: refactor-processRouterDest * feat: refactor-processRouterDest * feat: refactor-processRouterDest (#1688) * feat: refactor-processRouterDest (#1689) * feat: refactor router transformer - 4 (#1690) * feat: refactor-processRouterDest * feat: refactor-processRouterDest * fix: incorrect usages of error types (#1691) * fix: remove all usages of TRANSFORMER_METRIC * fixcorrect usages of error types * feat: add assertConfig default binding * chore: remove unwanted arguments from function definition * chore: remove unwanted null * chore: simplified the syntax * fix: set default status code * chore: use optional chaining syntax * fix: remove unwanted status code argument * feat: destType removed (#1692) * feat: refactor error types - review comments (#1697) * fix: refactor error types * fix: rt workflow to send stat tags in pinterest tag * fix: router transform issues in marketo_static_list * fix: restore router transform implementation * fix: issues in router transformation across destinations Co-authored-by: saikumarrs <saibattinoju@rudderstack.com> * fix: final review issues (#1699) * chore: add workspaceId as stat-tag (#1700) Co-authored-by: Sai Sankeerth <sanpj2292@github.com> * feat: add error handling for CDK v1 (#1698) * fix: add parsed response in network error (#1704) * fix[gaec]: revert destination response * fix: authErrorCategory field in the response Co-authored-by: saikumarrs <saibattinoju@rudderstack.com> * fix: destinations network error responses (#1705) * refactor: error handler for user deletion * feat(destination): onboard discord * chore: added testcases * fix: comments addressed * fix: comments addressed+1 * fix: comments addressed+2 * fix: comments addressed+3 * feat: add embed template with test cases Co-authored-by: saikumarrs <saibattinoju@rudderstack.com> Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com> Co-authored-by: Krishna Chaitanya <chaithu.kitti@gmail.com> Co-authored-by: Ujjwal Abhishek <63387036+ujjwal-ab@users.noreply.github.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: Sankeerth <sankeerth@rudderstack.com> Co-authored-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Anant <anant@rudderstack.com>

feat: new error types for destinations

9e3c3ff

mihir-4116 added the Ready for Review label Dec 13, 2022

mihir-4116 requested review from koladilip and saikumarrs December 13, 2022 05:17

mihir-4116 requested a review from a team as a code owner December 13, 2022 05:17

mihir-4116 self-assigned this Dec 13, 2022

koladilip approved these changes Dec 13, 2022

View reviewed changes

saikumarrs approved these changes Dec 13, 2022

View reviewed changes

saikumarrs added the Error refactor label Dec 13, 2022

feat: code review changes

b6eb156

mihir-4116 requested review from koladilip and saikumarrs December 13, 2022 05:49

saikumarrs approved these changes Dec 13, 2022

View reviewed changes

utsabc reviewed Dec 13, 2022

View reviewed changes

feat: code review changes

4455c89

mihir-4116 requested review from utsabc and saikumarrs and removed request for utsabc December 13, 2022 08:13

saikumarrs reviewed Dec 13, 2022

View reviewed changes

src/v0/destinations/snapchat_custom_audience/utils.js Outdated Show resolved Hide resolved

feat: code review changes

cfc4471

mihir-4116 requested a review from saikumarrs December 14, 2022 03:11

feat: code review changes

fb093e7

saikumarrs approved these changes Dec 14, 2022

View reviewed changes

utsabc approved these changes Dec 14, 2022

View reviewed changes

mihir-4116 merged commit fdbce18 into feat.new-error-types Dec 14, 2022

github-actions bot deleted the feat.destination.betch-4 branch March 15, 2023 02:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: new error types for destinations (snapchat_custom_audience, snapchat_conversion, slack, singular, signl4) #1655

feat: new error types for destinations (snapchat_custom_audience, snapchat_conversion, slack, singular, signl4) #1655

mihir-4116 commented Dec 13, 2022

koladilip Dec 13, 2022

mihir-4116 Dec 13, 2022

koladilip Dec 13, 2022

mihir-4116 Dec 13, 2022

utsabc Dec 13, 2022

utsabc Dec 13, 2022

utsabc Dec 13, 2022

utsabc Dec 13, 2022

utsabc Dec 13, 2022

utsabc Dec 13, 2022

utsabc Dec 13, 2022

utsabc Dec 13, 2022

utsabc Dec 13, 2022

utsabc Dec 13, 2022

	throw new ConfigurationError("apiKey is a required field");
	throw new ConfigurationError("ApiKey is a required field");

	throw new InstrumentationError("event name is not present for the event");
	throw new InstrumentationError("Event name is not present for the event");

	throw new InstrumentationError("Platform is not supported");
	throw new InstrumentationError(`Platform ${platform} is not supported`);

feat: new error types for destinations (snapchat_custom_audience, snapchat_conversion, slack, singular, signl4) #1655

feat: new error types for destinations (snapchat_custom_audience, snapchat_conversion, slack, singular, signl4) #1655

Conversation

mihir-4116 commented Dec 13, 2022

Description of the change

Type of change

Related issues

Checklists

Development

Code review

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment