-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor all instances of previous error types #1680
Merged
saikumarrs
merged 5 commits into
feat.new-error-types
from
refactor.remove-all-old-err-refs
Dec 15, 2022
Merged
chore: refactor all instances of previous error types #1680
saikumarrs
merged 5 commits into
feat.new-error-types
from
refactor.remove-all-old-err-refs
Dec 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koladilip
approved these changes
Dec 15, 2022
utsabc
approved these changes
Dec 15, 2022
saikumarrs
added a commit
that referenced
this pull request
Dec 20, 2022
* feat: introduce new tags and error classes * refactor: rename function as per latest implementation * refactor: replace ErrorBuilder with error type * fix: removed the ability to set stat tags externally in specific error types * feat: add destination and source ID tags * refactor: rename DefaultError to BaseError * fix: allow only error type and meta tags to be set in NetworkError class * fix: typo * refactor: replace with new error classes in GAOC destination * fix: remove error handling in proxy.test.js * fix: remove older stats and error types * chore(core): add internal code documentation Co-authored-by: Krishna Chaitanya <chaithu.kitti@gmail.com> * feat: revamp cdk V2 error handling (#1647) * feat: revamp cdk V2 error handling * fix: revert previously committed unwanted files * refactor: replace all references of CustomError in core (#1644) * fix: do not export CustomError * refactor: remove deprecated modules * refactor: replace all instances of CustomError in the core module * test: fix generic proxy test suite failures (#1656) * refactor: use new error types (#1658) * refactor: use new error types * fix: use the right error type * Revert "fix: use the right error type" This reverts commit 2887f3a. * feat: refactor new error types (ga360, gainsight, gainsight_px, google_cloud_function, googlepubsnub) (#1665) * feat:[ga360] add new errorTypes * feat:[google_cloud_function] add new errorTypes * feat:[googlepubsnub] add new errorTypes * feat:[gainsight_px] add new errorTypes * feat:[gainsight] add new errorTypes * feat: refactor new error types (awin, blueshift, bqstream, branch, braze) (#1649) * feat:[awin] add new error types * feat:[blueshift] add new error types * feat:[bqstream] add new error types * feat:[branch] add new error types * feat:[braze] add new error types * feat: refactor new error types (facebook_offline_conversions, facebook_pixel, factorsai, fb, fb_custom_audience) (#1652) * feat:[facebook_offline_conversions] add new errorTypes * feat:[facebook_pixel] add new errorTypes * feat:[factorsai] add new errorTypes * feat:[factorsai] add new errorTypes * feat:[fb] add new errorTypes * feat:[fb_custom_audience] add new errorTypes * fix: refactor error message and unit tests * feat: update error message * feat: refactor new error types (custify, customerio, delighted, engage, eventbridge) (#1651) * feat:[custify] add new error types * feat:[customerio] add new error types * feat:[customerio] add statTags in processRouterDest * feat:[delighted] add new errorTypes * feat:[engage] add new errorTypes * feat:[eventbridge] add new errorTypes * feat: new error types for destinations(mailmodo, mailchimp, lytics, leanplum, lambda) (#1669) * feat: new error types for destinations * feat: code review changes * feat: update new error types (#1673) * feat: new error types for user.com destination (#1638) * feat: new error types for user.com destination * feat: code review changes * feat: new error types for sources (appcenter, appsflyer, braze, canny) (#1641) * feat: new error types for sources * feat: code review changes * feat: new error types for destinations (trengo, userlist, variance, vero, webengage) (#1653) * feat: new error types for destinations * feat: code review changes * feat: code review changes * feat: new error types for destinations (#1661) * feat: new error types for destinations(persistiq, pardot, one_signal, ometria, mssql) (#1666) * feat: code review changes * feat: code review changes * feat: code review changes * feat: new error types for destinations(mixpanel, monetate, monday, moengage, minio) (#1667) * feat: new error types for destinations * feat: code review changes * feat: new error types for destinations(kustomer, kochava, klaviyo, kissmetrics, keen) (#1671) * feat: new error types for destinations * feat: code review changes * feat: new error types for destinations (rockerbox, revenue_cat, redis, refiner) (#1659) * feat: new error types for destinations * feat: code review changes * feat: new error types for destinations (tiktok_ads, statsig, splitio, snowflake) (#1654) * feat: new error types for destinations * feat: code review changes * feat: new error types for destinations (snapchat_custom_audience, snapchat_conversion, slack, singular, signl4) (#1655) * feat: new error types for destinations * feat: code review changes * feat: code review changes * feat: code review changes * feat: code review changes * feat: refactor new error types (google_adwords_enhanced_conversion, google_adwords_offline_conversion, google_adwords_remarketing_lists, heap, googlesheets (#1670) * feat:[google_adwords_enhanced_conversions] update new error types * feat:[google_adwords_remarketing_lists] update new error types * feat:[googlesheets] update new error types * feat:[google_adwords_offline_conversion] update new error types * feat:[heap] update new error types * feat: update new error types * feat: new error types for destinations(shynet, sfmc, serenytics, sendgrid, segment) (#1657) * feat: new error types for destinationss * feat: code review changes * feat: code review changes * feat: refactor new error types (hs, indicative, itercom, iterable, drip) (#1672) * feat:[HS] update new error types * feat:[indicative] update new error types * feat:[indicative] update new error types * feat:[intercom] update new error types * feat:[iterable] update new error types * feat:update new error types * feat:[drip] update new error types * feat: update new error types * feat: update new error types * feat: new error types for sources (gainsightpx, iterable, mailmodo, monday, shopify) (#1642) * feat: new error types for sources * feat: code review changes * feat: new error types for destinations (webhook, wootric, woopra, yahoo_dsp, zendesk) (#1645) * feat: new error types for destinations * feat: code review changes * feat: code review changes * feat: code review changes * feat: refactor new error types (campaign_manager, candu, canny, clevertap, confluent_cloud) (#1650) * feat:[campaign_manager] add new error types * feat:[candu] add new error types * feat:[canny] add new error types * feat:[clevertap] add new error types * feat:[confluent_cloud] add new error types * feat: add new errorTypes * feat: update new error types * feat: add new error types ( active_campaign, adjust, adobe_analytics, appsflyer, airship) (#1639) * feat:[active_campaign] add new error types * feat:[adj] add new error types * feat:[adobe_analytics] add new error types * feat:[appsFlyer] add new error types * feat:[airship] add new error types * feat:[active_campaign] update new error type for axios calls * feat: update new error types * feat: update new error types * feat: update new error types * feat: update new error types * feat: new error types for destinations(marketo, marketo_static_list, marketo_bulk_upload) (#1674) * feat: new error types for destinations * feat: code review changes * feat: code review changes * feat: code review changes * feat: code review changes * feat: code review changes * feat: add new errorTypes (firehose, freshsales, freshmarketer, ga, ga4) (#1660) * feat: add new errorTypes * feat: update new error types * feat: update new error types * feat: update new error types * feat: refactor new error types ( amplitude, algolia, appcues, attentive_tag, attribution, autopilot) (#1648) * feat:[algolia] add new error types * feat:[appcues] add new error types * feat: add new error types * feat: add new error types * feat:[autopilot] add new error types * feat: add new error types * feat: update new error types * feat: update new error types * fix: heap test cases (#1675) * feat: refactor-dcm_floodlight-cdk-errorTypes (#1677) * feat: refactor-dcm_floodlight-cdk-errorTypes * fix: june tests * fix: proxy test cases (#1678) * fix: proxy test cases * fix: code review changes * fix: code review changes * feat: refactor router transform implementation (#1676) * feat: revamped router transform logic * fix: revert previously committed unwanted files * fix: replace flowtype with feature * refactor: use default error message * fix: return response * refactor: extract redundant code to a utility method * chore: refactor all instances of previous error types (#1680) * refactor: replace final instances of old error types with new error types * fix: typo * fix: revert previously committed file * refactor: remove unwanted comments * fix: user deletion test cases (#1682) * fix: pinterest and algolia cdk test cases (#1681) * fix: pinterest cdk test cases * fix: code review changes * fix: code review changes * fix: code review changes * feat: router tranform refacor for destinations (batch - 1) (#1684) * feat: router tranform refacor * feat: router tranform refacor * feat: code review changes * feat: code review changes * feat: router tranform refacor (#1685) * feat: router tranform refacor for destinations (batch - 3) (#1686) * feat: router tranform refacor * feat: router tranform refactor * feat: code review changes * feat: refactor router transformer - 1 (#1687) * feat: refactor-processRouterDest * feat: refactor-processRouterDest * feat: refactor-processRouterDest (#1688) * feat: refactor-processRouterDest (#1689) * feat: refactor router transformer - 4 (#1690) * feat: refactor-processRouterDest * feat: refactor-processRouterDest * fix: incorrect usages of error types (#1691) * fix: remove all usages of TRANSFORMER_METRIC * fixcorrect usages of error types * feat: add assertConfig default binding * chore: remove unwanted arguments from function definition * chore: remove unwanted null * chore: simplified the syntax * fix: set default status code * chore: use optional chaining syntax * fix: remove unwanted status code argument * feat: destType removed (#1692) * feat: refactor error types - review comments (#1697) * fix: refactor error types * fix: rt workflow to send stat tags in pinterest tag * fix: router transform issues in marketo_static_list * fix: restore router transform implementation * fix: issues in router transformation across destinations Co-authored-by: saikumarrs <saibattinoju@rudderstack.com> * fix: final review issues (#1699) * chore: add workspaceId as stat-tag (#1700) Co-authored-by: Sai Sankeerth <sanpj2292@github.com> * feat: add error handling for CDK v1 (#1698) * fix: add parsed response in network error (#1704) * fix[gaec]: revert destination response * fix: authErrorCategory field in the response Co-authored-by: saikumarrs <saibattinoju@rudderstack.com> * fix: destinations network error responses (#1705) * refactor: error handler for user deletion Co-authored-by: Krishna Chaitanya <chaithu.kitti@gmail.com> Co-authored-by: Ujjwal Abhishek <63387036+ujjwal-ab@users.noreply.github.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: Sankeerth <sankeerth@rudderstack.com> Co-authored-by: Sai Sankeerth <sanpj2292@github.com>
anantjain45823
added a commit
that referenced
this pull request
Jan 4, 2023
* feat: introduce new tags and error classes * refactor: rename function as per latest implementation * refactor: replace ErrorBuilder with error type * fix: removed the ability to set stat tags externally in specific error types * feat: add destination and source ID tags * refactor: rename DefaultError to BaseError * fix: allow only error type and meta tags to be set in NetworkError class * fix: typo * refactor: replace with new error classes in GAOC destination * fix: remove error handling in proxy.test.js * fix: remove older stats and error types * chore(core): add internal code documentation Co-authored-by: Krishna Chaitanya <chaithu.kitti@gmail.com> * feat: revamp cdk V2 error handling (#1647) * feat: revamp cdk V2 error handling * fix: revert previously committed unwanted files * refactor: replace all references of CustomError in core (#1644) * fix: do not export CustomError * refactor: remove deprecated modules * refactor: replace all instances of CustomError in the core module * test: fix generic proxy test suite failures (#1656) * refactor: use new error types (#1658) * refactor: use new error types * fix: use the right error type * Revert "fix: use the right error type" This reverts commit 2887f3a. * feat: refactor new error types (ga360, gainsight, gainsight_px, google_cloud_function, googlepubsnub) (#1665) * feat:[ga360] add new errorTypes * feat:[google_cloud_function] add new errorTypes * feat:[googlepubsnub] add new errorTypes * feat:[gainsight_px] add new errorTypes * feat:[gainsight] add new errorTypes * feat: refactor new error types (awin, blueshift, bqstream, branch, braze) (#1649) * feat:[awin] add new error types * feat:[blueshift] add new error types * feat:[bqstream] add new error types * feat:[branch] add new error types * feat:[braze] add new error types * feat: refactor new error types (facebook_offline_conversions, facebook_pixel, factorsai, fb, fb_custom_audience) (#1652) * feat:[facebook_offline_conversions] add new errorTypes * feat:[facebook_pixel] add new errorTypes * feat:[factorsai] add new errorTypes * feat:[factorsai] add new errorTypes * feat:[fb] add new errorTypes * feat:[fb_custom_audience] add new errorTypes * fix: refactor error message and unit tests * feat: update error message * feat: refactor new error types (custify, customerio, delighted, engage, eventbridge) (#1651) * feat:[custify] add new error types * feat:[customerio] add new error types * feat:[customerio] add statTags in processRouterDest * feat:[delighted] add new errorTypes * feat:[engage] add new errorTypes * feat:[eventbridge] add new errorTypes * feat: new error types for destinations(mailmodo, mailchimp, lytics, leanplum, lambda) (#1669) * feat: new error types for destinations * feat: code review changes * feat: update new error types (#1673) * feat: new error types for user.com destination (#1638) * feat: new error types for user.com destination * feat: code review changes * feat: new error types for sources (appcenter, appsflyer, braze, canny) (#1641) * feat: new error types for sources * feat: code review changes * feat: new error types for destinations (trengo, userlist, variance, vero, webengage) (#1653) * feat: new error types for destinations * feat: code review changes * feat: code review changes * feat: new error types for destinations (#1661) * feat: new error types for destinations(persistiq, pardot, one_signal, ometria, mssql) (#1666) * feat: code review changes * feat: code review changes * feat: code review changes * feat: new error types for destinations(mixpanel, monetate, monday, moengage, minio) (#1667) * feat: new error types for destinations * feat: code review changes * feat: new error types for destinations(kustomer, kochava, klaviyo, kissmetrics, keen) (#1671) * feat: new error types for destinations * feat: code review changes * feat: new error types for destinations (rockerbox, revenue_cat, redis, refiner) (#1659) * feat: new error types for destinations * feat: code review changes * feat: new error types for destinations (tiktok_ads, statsig, splitio, snowflake) (#1654) * feat: new error types for destinations * feat: code review changes * feat: new error types for destinations (snapchat_custom_audience, snapchat_conversion, slack, singular, signl4) (#1655) * feat: new error types for destinations * feat: code review changes * feat: code review changes * feat: code review changes * feat: code review changes * feat: refactor new error types (google_adwords_enhanced_conversion, google_adwords_offline_conversion, google_adwords_remarketing_lists, heap, googlesheets (#1670) * feat:[google_adwords_enhanced_conversions] update new error types * feat:[google_adwords_remarketing_lists] update new error types * feat:[googlesheets] update new error types * feat:[google_adwords_offline_conversion] update new error types * feat:[heap] update new error types * feat: update new error types * feat: new error types for destinations(shynet, sfmc, serenytics, sendgrid, segment) (#1657) * feat: new error types for destinationss * feat: code review changes * feat: code review changes * feat: refactor new error types (hs, indicative, itercom, iterable, drip) (#1672) * feat:[HS] update new error types * feat:[indicative] update new error types * feat:[indicative] update new error types * feat:[intercom] update new error types * feat:[iterable] update new error types * feat:update new error types * feat:[drip] update new error types * feat: update new error types * feat: update new error types * feat: new error types for sources (gainsightpx, iterable, mailmodo, monday, shopify) (#1642) * feat: new error types for sources * feat: code review changes * feat: new error types for destinations (webhook, wootric, woopra, yahoo_dsp, zendesk) (#1645) * feat: new error types for destinations * feat: code review changes * feat: code review changes * feat: code review changes * feat: refactor new error types (campaign_manager, candu, canny, clevertap, confluent_cloud) (#1650) * feat:[campaign_manager] add new error types * feat:[candu] add new error types * feat:[canny] add new error types * feat:[clevertap] add new error types * feat:[confluent_cloud] add new error types * feat: add new errorTypes * feat: update new error types * feat: add new error types ( active_campaign, adjust, adobe_analytics, appsflyer, airship) (#1639) * feat:[active_campaign] add new error types * feat:[adj] add new error types * feat:[adobe_analytics] add new error types * feat:[appsFlyer] add new error types * feat:[airship] add new error types * feat:[active_campaign] update new error type for axios calls * feat: update new error types * feat: update new error types * feat: update new error types * feat: update new error types * feat: new error types for destinations(marketo, marketo_static_list, marketo_bulk_upload) (#1674) * feat: new error types for destinations * feat: code review changes * feat: code review changes * feat: code review changes * feat: code review changes * feat: code review changes * feat: add new errorTypes (firehose, freshsales, freshmarketer, ga, ga4) (#1660) * feat: add new errorTypes * feat: update new error types * feat: update new error types * feat: update new error types * feat: refactor new error types ( amplitude, algolia, appcues, attentive_tag, attribution, autopilot) (#1648) * feat:[algolia] add new error types * feat:[appcues] add new error types * feat: add new error types * feat: add new error types * feat:[autopilot] add new error types * feat: add new error types * feat: update new error types * feat: update new error types * fix: heap test cases (#1675) * feat: refactor-dcm_floodlight-cdk-errorTypes (#1677) * feat: refactor-dcm_floodlight-cdk-errorTypes * fix: june tests * fix: proxy test cases (#1678) * fix: proxy test cases * fix: code review changes * fix: code review changes * feat: refactor router transform implementation (#1676) * feat: revamped router transform logic * fix: revert previously committed unwanted files * fix: replace flowtype with feature * refactor: use default error message * fix: return response * refactor: extract redundant code to a utility method * chore: refactor all instances of previous error types (#1680) * refactor: replace final instances of old error types with new error types * fix: typo * fix: revert previously committed file * refactor: remove unwanted comments * fix: user deletion test cases (#1682) * fix: pinterest and algolia cdk test cases (#1681) * fix: pinterest cdk test cases * fix: code review changes * fix: code review changes * fix: code review changes * feat: router tranform refacor for destinations (batch - 1) (#1684) * feat: router tranform refacor * feat: router tranform refacor * feat: code review changes * feat: code review changes * feat: router tranform refacor (#1685) * feat: router tranform refacor for destinations (batch - 3) (#1686) * feat: router tranform refacor * feat: router tranform refactor * feat: code review changes * feat: refactor router transformer - 1 (#1687) * feat: refactor-processRouterDest * feat: refactor-processRouterDest * feat: refactor-processRouterDest (#1688) * feat: refactor-processRouterDest (#1689) * feat: refactor router transformer - 4 (#1690) * feat: refactor-processRouterDest * feat: refactor-processRouterDest * fix: incorrect usages of error types (#1691) * fix: remove all usages of TRANSFORMER_METRIC * fixcorrect usages of error types * feat: add assertConfig default binding * chore: remove unwanted arguments from function definition * chore: remove unwanted null * chore: simplified the syntax * fix: set default status code * chore: use optional chaining syntax * fix: remove unwanted status code argument * feat: destType removed (#1692) * feat: refactor error types - review comments (#1697) * fix: refactor error types * fix: rt workflow to send stat tags in pinterest tag * fix: router transform issues in marketo_static_list * fix: restore router transform implementation * fix: issues in router transformation across destinations Co-authored-by: saikumarrs <saibattinoju@rudderstack.com> * fix: final review issues (#1699) * chore: add workspaceId as stat-tag (#1700) Co-authored-by: Sai Sankeerth <sanpj2292@github.com> * feat: add error handling for CDK v1 (#1698) * fix: add parsed response in network error (#1704) * fix[gaec]: revert destination response * fix: authErrorCategory field in the response Co-authored-by: saikumarrs <saibattinoju@rudderstack.com> * fix: destinations network error responses (#1705) * refactor: error handler for user deletion * feat(destination): onboard discord * chore: added testcases * fix: comments addressed * fix: comments addressed+1 * fix: comments addressed+2 * fix: comments addressed+3 * feat: add embed template with test cases Co-authored-by: saikumarrs <saibattinoju@rudderstack.com> Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com> Co-authored-by: Krishna Chaitanya <chaithu.kitti@gmail.com> Co-authored-by: Ujjwal Abhishek <63387036+ujjwal-ab@users.noreply.github.com> Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com> Co-authored-by: Sankeerth <sankeerth@rudderstack.com> Co-authored-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Anant <anant@rudderstack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Replaced all the leftover instances of previous error types.
Type of change
Related issues
N/A
Checklists
Development
Code review