Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor router transform implementation #1676

Merged
merged 8 commits into from
Dec 15, 2022
Merged

feat: refactor router transform implementation #1676

merged 8 commits into from
Dec 15, 2022

Conversation

saikumarrs
Copy link
Member

@saikumarrs saikumarrs commented Dec 14, 2022 •
edited
Loading

Description of the change

Refactored router transform implementation.
It was missing two things:

  • Bugsnag notifications (both at event level error handler and the global one)
  • Translation of the handled error to the newly added error types

To send errors to Bugsnag with rich metadata, we have changed the signature of processRouterDest to accept a new argument, reqMetadata.

Some other minor updates:

  • flowType to feature name change in CDK v2 flow
  • The default error type is changed to TransformationError. It is functionally same as the previous logic.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

N/A

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@saikumarrs saikumarrs self-assigned this Dec 14, 2022
koladilip
koladilip reviewed Dec 15, 2022
View reviewed changes
src/v0/destinations/am/transform.js Show resolved Hide resolved
src/v0/util/index.js Outdated Show resolved Hide resolved
@mihir-4116 mihir-4116 self-requested a review December 15, 2022 06:48
@saikumarrs saikumarrs marked this pull request as ready for review December 15, 2022 07:00
@saikumarrs saikumarrs requested review from a team and sivashanmukh as code owners December 15, 2022 07:00
@saikumarrs saikumarrs merged commit 60f5de7 into feat.new-error-types Dec 15, 2022
saikumarrs added a commit that referenced this pull request Dec 20, 2022
@saikumarrs @krishna2020
@ujjwal-ab @mihir-4116 @sanpj2292
feat: introduce new tags and error classes (#1631)
0615a31 
* feat: introduce new tags and error classes

* refactor: rename function as per latest implementation

* refactor: replace ErrorBuilder with error type

* fix: removed the ability to set stat tags externally in specific error types

* feat: add destination and source ID tags

* refactor: rename DefaultError to BaseError

* fix: allow only error type and meta tags to be set in NetworkError class

* fix: typo

* refactor: replace with new error classes in GAOC destination

* fix: remove error handling in proxy.test.js

* fix: remove older stats and error types

* chore(core): add internal code documentation

Co-authored-by: Krishna Chaitanya <chaithu.kitti@gmail.com>

* feat: revamp cdk V2 error handling (#1647)

* feat: revamp cdk V2 error handling

* fix: revert previously committed unwanted files

* refactor: replace all references of CustomError in core (#1644)

* fix: do not export CustomError

* refactor: remove deprecated modules

* refactor: replace all instances of CustomError in the core module

* test: fix generic proxy test suite failures (#1656)

* refactor: use new error types (#1658)

* refactor: use new error types

* fix: use the right error type

* Revert "fix: use the right error type"

This reverts commit 2887f3a.

* feat: refactor new error types (ga360, gainsight, gainsight_px, google_cloud_function, googlepubsnub) (#1665)

* feat:[ga360] add new errorTypes

* feat:[google_cloud_function] add new errorTypes

* feat:[googlepubsnub] add new errorTypes

* feat:[gainsight_px] add new errorTypes

* feat:[gainsight] add new errorTypes

* feat: refactor new error types (awin, blueshift, bqstream, branch, braze) (#1649)

* feat:[awin] add new error types

* feat:[blueshift] add new error types

* feat:[bqstream] add new error types

* feat:[branch] add new error types

* feat:[braze] add new error types

* feat: refactor new error types (facebook_offline_conversions, facebook_pixel, factorsai, fb, fb_custom_audience) (#1652)

* feat:[facebook_offline_conversions] add new errorTypes

* feat:[facebook_pixel] add new errorTypes

* feat:[factorsai] add new errorTypes

* feat:[factorsai] add new errorTypes

* feat:[fb] add new errorTypes

* feat:[fb_custom_audience] add new errorTypes

* fix: refactor error  message and unit tests

* feat: update error message

* feat: refactor new error types (custify, customerio, delighted, engage, eventbridge) (#1651)

* feat:[custify] add new error types

* feat:[customerio] add new error types

* feat:[customerio] add statTags in processRouterDest

* feat:[delighted] add new errorTypes

* feat:[engage] add new errorTypes

* feat:[eventbridge] add new errorTypes

* feat: new error types for destinations(mailmodo, mailchimp, lytics, leanplum, lambda) (#1669)

* feat: new error types for destinations

* feat: code review changes

* feat: update new error types (#1673)

* feat: new error types for user.com destination (#1638)

* feat: new error types for user.com destination

* feat: code review changes

* feat: new error types for sources (appcenter, appsflyer, braze, canny) (#1641)

* feat: new error types for sources

* feat: code review changes

* feat: new error types for destinations (trengo, userlist, variance, vero, webengage) (#1653)

* feat: new error types for destinations

* feat: code review changes

* feat: code review changes

* feat: new error types for destinations (#1661)

* feat: new error types for destinations(persistiq, pardot, one_signal, ometria, mssql) (#1666)

* feat: code review changes

* feat: code review changes

* feat: code review changes

* feat: new error types for destinations(mixpanel, monetate, monday, moengage, minio) (#1667)

* feat: new error types for destinations

* feat: code review changes

* feat: new error types for destinations(kustomer, kochava, klaviyo, kissmetrics, keen) (#1671)

* feat: new error types for destinations

* feat: code review changes

* feat: new error types for destinations (rockerbox, revenue_cat, redis, refiner) (#1659)

* feat: new error types for destinations

* feat: code review changes

* feat: new error types for destinations (tiktok_ads, statsig, splitio, snowflake)  (#1654)

* feat: new error types for destinations

* feat: code review changes

* feat: new error types for destinations (snapchat_custom_audience, snapchat_conversion, slack, singular, signl4) (#1655)

* feat: new error types for destinations

* feat: code review changes

* feat: code review changes

* feat: code review changes

* feat: code review changes

* feat: refactor new error types (google_adwords_enhanced_conversion, google_adwords_offline_conversion, google_adwords_remarketing_lists, heap, googlesheets (#1670)

* feat:[google_adwords_enhanced_conversions] update new error types

* feat:[google_adwords_remarketing_lists] update new error types

* feat:[googlesheets] update new error types

* feat:[google_adwords_offline_conversion] update new error types

* feat:[heap] update new error types

* feat: update new error types

* feat: new error types for destinations(shynet, sfmc, serenytics, sendgrid, segment) (#1657)

* feat: new error types for destinationss

* feat: code review changes

* feat: code review changes

* feat: refactor new error types (hs, indicative, itercom, iterable, drip) (#1672)

* feat:[HS] update new error types

* feat:[indicative] update new error types

* feat:[indicative] update new error types

* feat:[intercom] update new error types

* feat:[iterable] update new error types

* feat:update new error types

* feat:[drip] update new error types

* feat: update new error types

* feat: update new error types

* feat: new error types for sources (gainsightpx, iterable, mailmodo, monday, shopify)  (#1642)

* feat: new error types for sources

* feat: code review changes

* feat: new error types for destinations (webhook, wootric, woopra, yahoo_dsp, zendesk) (#1645)

* feat: new error types for destinations

* feat: code review changes

* feat: code review changes

* feat: code review changes

* feat: refactor new error types (campaign_manager, candu, canny, clevertap, confluent_cloud) (#1650)

* feat:[campaign_manager] add new error types

* feat:[candu] add new error types

* feat:[canny] add new error types

* feat:[clevertap] add new error types

* feat:[confluent_cloud] add new error types

* feat: add new errorTypes

* feat: update new error types

* feat: add new error types ( active_campaign, adjust, adobe_analytics, appsflyer, airship) (#1639)

* feat:[active_campaign] add new error types

* feat:[adj] add new error types

* feat:[adobe_analytics] add new error types

* feat:[appsFlyer] add new error types

* feat:[airship] add new error types

* feat:[active_campaign] update new error type for axios calls

* feat: update new error types

* feat: update new error types

* feat: update new error types

* feat: update new error types

* feat: new error types for destinations(marketo, marketo_static_list, marketo_bulk_upload) (#1674)

* feat: new error types for destinations

* feat: code review changes

* feat: code review changes

* feat: code review changes

* feat: code review changes

* feat: code review changes

* feat: add new errorTypes (firehose, freshsales, freshmarketer, ga, ga4) (#1660)

* feat: add new errorTypes

* feat: update new error types

* feat: update new error types

* feat: update new error types

* feat: refactor new error types ( amplitude, algolia, appcues, attentive_tag, attribution, autopilot) (#1648)

* feat:[algolia] add new error types

* feat:[appcues] add new error types

* feat: add new error types

* feat: add new error types

* feat:[autopilot] add new error types

* feat: add new error types

* feat: update new error types

* feat: update new error types

* fix: heap test cases (#1675)

* feat: refactor-dcm_floodlight-cdk-errorTypes (#1677)

* feat: refactor-dcm_floodlight-cdk-errorTypes

* fix: june tests

* fix: proxy test cases (#1678)

* fix: proxy test cases

* fix: code review changes

* fix: code review changes

* feat: refactor router transform implementation (#1676)

* feat: revamped router transform logic

* fix: revert previously committed unwanted files

* fix: replace flowtype with feature

* refactor: use default error message

* fix: return response

* refactor: extract redundant code to a utility method

* chore: refactor all instances of previous error types (#1680)

* refactor: replace final instances of old error types with new error types

* fix: typo

* fix: revert previously committed file

* refactor: remove unwanted comments

* fix: user deletion test cases (#1682)

* fix: pinterest and algolia cdk test cases (#1681)

* fix: pinterest cdk test cases

* fix: code review changes

* fix: code review changes

* fix: code review changes

* feat: router tranform refacor for destinations (batch - 1) (#1684)

* feat: router tranform refacor

* feat: router tranform refacor

* feat: code review changes

* feat: code review changes

* feat: router tranform refacor (#1685)

* feat: router tranform refacor for destinations (batch - 3) (#1686)

* feat: router tranform refacor

* feat: router tranform refactor

* feat: code review changes

* feat: refactor router transformer - 1 (#1687)

* feat: refactor-processRouterDest

* feat: refactor-processRouterDest

* feat: refactor-processRouterDest (#1688)

* feat: refactor-processRouterDest (#1689)

* feat: refactor router transformer - 4 (#1690)

* feat: refactor-processRouterDest

* feat: refactor-processRouterDest

* fix: incorrect usages of error types (#1691)

* fix: remove all usages of TRANSFORMER_METRIC

* fixcorrect usages of error types

* feat: add assertConfig default binding

* chore: remove unwanted arguments from function definition

* chore: remove unwanted null

* chore: simplified the syntax

* fix: set default status code

* chore: use optional chaining syntax

* fix: remove unwanted status code argument

* feat: destType removed (#1692)

* feat: refactor error types - review comments (#1697)

* fix: refactor error types

* fix: rt workflow to send stat tags in pinterest tag

* fix: router transform issues in marketo_static_list

* fix: restore router transform implementation

* fix: issues in router transformation across destinations

Co-authored-by: saikumarrs <saibattinoju@rudderstack.com>

* fix: final review issues (#1699)

* chore: add workspaceId as stat-tag (#1700)

Co-authored-by: Sai Sankeerth <sanpj2292@github.com>

* feat: add error handling for CDK v1 (#1698)

* fix: add parsed response in network error (#1704)

* fix[gaec]: revert destination response

* fix: authErrorCategory field in the response

Co-authored-by: saikumarrs <saibattinoju@rudderstack.com>

* fix: destinations network error responses (#1705)

* refactor: error handler for user deletion

Co-authored-by: Krishna Chaitanya <chaithu.kitti@gmail.com>
Co-authored-by: Ujjwal Abhishek <63387036+ujjwal-ab@users.noreply.github.com>
Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com>
Co-authored-by: Sankeerth <sankeerth@rudderstack.com>
Co-authored-by: Sai Sankeerth <sanpj2292@github.com>
anantjain45823 added a commit that referenced this pull request Jan 4, 2023
@anantjain45823 @saikumarrs
@krishna2020 @ujjwal-ab @mihir-4116 @sanpj2292 @anantrudder
feat(destination): onboard discord (#1725)
4f6323b 
* feat: introduce new tags and error classes

* refactor: rename function as per latest implementation

* refactor: replace ErrorBuilder with error type

* fix: removed the ability to set stat tags externally in specific error types

* feat: add destination and source ID tags

* refactor: rename DefaultError to BaseError

* fix: allow only error type and meta tags to be set in NetworkError class

* fix: typo

* refactor: replace with new error classes in GAOC destination

* fix: remove error handling in proxy.test.js

* fix: remove older stats and error types

* chore(core): add internal code documentation

Co-authored-by: Krishna Chaitanya <chaithu.kitti@gmail.com>

* feat: revamp cdk V2 error handling (#1647)

* feat: revamp cdk V2 error handling

* fix: revert previously committed unwanted files

* refactor: replace all references of CustomError in core (#1644)

* fix: do not export CustomError

* refactor: remove deprecated modules

* refactor: replace all instances of CustomError in the core module

* test: fix generic proxy test suite failures (#1656)

* refactor: use new error types (#1658)

* refactor: use new error types

* fix: use the right error type

* Revert "fix: use the right error type"

This reverts commit 2887f3a.

* feat: refactor new error types (ga360, gainsight, gainsight_px, google_cloud_function, googlepubsnub) (#1665)

* feat:[ga360] add new errorTypes

* feat:[google_cloud_function] add new errorTypes

* feat:[googlepubsnub] add new errorTypes

* feat:[gainsight_px] add new errorTypes

* feat:[gainsight] add new errorTypes

* feat: refactor new error types (awin, blueshift, bqstream, branch, braze) (#1649)

* feat:[awin] add new error types

* feat:[blueshift] add new error types

* feat:[bqstream] add new error types

* feat:[branch] add new error types

* feat:[braze] add new error types

* feat: refactor new error types (facebook_offline_conversions, facebook_pixel, factorsai, fb, fb_custom_audience) (#1652)

* feat:[facebook_offline_conversions] add new errorTypes

* feat:[facebook_pixel] add new errorTypes

* feat:[factorsai] add new errorTypes

* feat:[factorsai] add new errorTypes

* feat:[fb] add new errorTypes

* feat:[fb_custom_audience] add new errorTypes

* fix: refactor error  message and unit tests

* feat: update error message

* feat: refactor new error types (custify, customerio, delighted, engage, eventbridge) (#1651)

* feat:[custify] add new error types

* feat:[customerio] add new error types

* feat:[customerio] add statTags in processRouterDest

* feat:[delighted] add new errorTypes

* feat:[engage] add new errorTypes

* feat:[eventbridge] add new errorTypes

* feat: new error types for destinations(mailmodo, mailchimp, lytics, leanplum, lambda) (#1669)

* feat: new error types for destinations

* feat: code review changes

* feat: update new error types (#1673)

* feat: new error types for user.com destination (#1638)

* feat: new error types for user.com destination

* feat: code review changes

* feat: new error types for sources (appcenter, appsflyer, braze, canny) (#1641)

* feat: new error types for sources

* feat: code review changes

* feat: new error types for destinations (trengo, userlist, variance, vero, webengage) (#1653)

* feat: new error types for destinations

* feat: code review changes

* feat: code review changes

* feat: new error types for destinations (#1661)

* feat: new error types for destinations(persistiq, pardot, one_signal, ometria, mssql) (#1666)

* feat: code review changes

* feat: code review changes

* feat: code review changes

* feat: new error types for destinations(mixpanel, monetate, monday, moengage, minio) (#1667)

* feat: new error types for destinations

* feat: code review changes

* feat: new error types for destinations(kustomer, kochava, klaviyo, kissmetrics, keen) (#1671)

* feat: new error types for destinations

* feat: code review changes

* feat: new error types for destinations (rockerbox, revenue_cat, redis, refiner) (#1659)

* feat: new error types for destinations

* feat: code review changes

* feat: new error types for destinations (tiktok_ads, statsig, splitio, snowflake)  (#1654)

* feat: new error types for destinations

* feat: code review changes

* feat: new error types for destinations (snapchat_custom_audience, snapchat_conversion, slack, singular, signl4) (#1655)

* feat: new error types for destinations

* feat: code review changes

* feat: code review changes

* feat: code review changes

* feat: code review changes

* feat: refactor new error types (google_adwords_enhanced_conversion, google_adwords_offline_conversion, google_adwords_remarketing_lists, heap, googlesheets (#1670)

* feat:[google_adwords_enhanced_conversions] update new error types

* feat:[google_adwords_remarketing_lists] update new error types

* feat:[googlesheets] update new error types

* feat:[google_adwords_offline_conversion] update new error types

* feat:[heap] update new error types

* feat: update new error types

* feat: new error types for destinations(shynet, sfmc, serenytics, sendgrid, segment) (#1657)

* feat: new error types for destinationss

* feat: code review changes

* feat: code review changes

* feat: refactor new error types (hs, indicative, itercom, iterable, drip) (#1672)

* feat:[HS] update new error types

* feat:[indicative] update new error types

* feat:[indicative] update new error types

* feat:[intercom] update new error types

* feat:[iterable] update new error types

* feat:update new error types

* feat:[drip] update new error types

* feat: update new error types

* feat: update new error types

* feat: new error types for sources (gainsightpx, iterable, mailmodo, monday, shopify)  (#1642)

* feat: new error types for sources

* feat: code review changes

* feat: new error types for destinations (webhook, wootric, woopra, yahoo_dsp, zendesk) (#1645)

* feat: new error types for destinations

* feat: code review changes

* feat: code review changes

* feat: code review changes

* feat: refactor new error types (campaign_manager, candu, canny, clevertap, confluent_cloud) (#1650)

* feat:[campaign_manager] add new error types

* feat:[candu] add new error types

* feat:[canny] add new error types

* feat:[clevertap] add new error types

* feat:[confluent_cloud] add new error types

* feat: add new errorTypes

* feat: update new error types

* feat: add new error types ( active_campaign, adjust, adobe_analytics, appsflyer, airship) (#1639)

* feat:[active_campaign] add new error types

* feat:[adj] add new error types

* feat:[adobe_analytics] add new error types

* feat:[appsFlyer] add new error types

* feat:[airship] add new error types

* feat:[active_campaign] update new error type for axios calls

* feat: update new error types

* feat: update new error types

* feat: update new error types

* feat: update new error types

* feat: new error types for destinations(marketo, marketo_static_list, marketo_bulk_upload) (#1674)

* feat: new error types for destinations

* feat: code review changes

* feat: code review changes

* feat: code review changes

* feat: code review changes

* feat: code review changes

* feat: add new errorTypes (firehose, freshsales, freshmarketer, ga, ga4) (#1660)

* feat: add new errorTypes

* feat: update new error types

* feat: update new error types

* feat: update new error types

* feat: refactor new error types ( amplitude, algolia, appcues, attentive_tag, attribution, autopilot) (#1648)

* feat:[algolia] add new error types

* feat:[appcues] add new error types

* feat: add new error types

* feat: add new error types

* feat:[autopilot] add new error types

* feat: add new error types

* feat: update new error types

* feat: update new error types

* fix: heap test cases (#1675)

* feat: refactor-dcm_floodlight-cdk-errorTypes (#1677)

* feat: refactor-dcm_floodlight-cdk-errorTypes

* fix: june tests

* fix: proxy test cases (#1678)

* fix: proxy test cases

* fix: code review changes

* fix: code review changes

* feat: refactor router transform implementation (#1676)

* feat: revamped router transform logic

* fix: revert previously committed unwanted files

* fix: replace flowtype with feature

* refactor: use default error message

* fix: return response

* refactor: extract redundant code to a utility method

* chore: refactor all instances of previous error types (#1680)

* refactor: replace final instances of old error types with new error types

* fix: typo

* fix: revert previously committed file

* refactor: remove unwanted comments

* fix: user deletion test cases (#1682)

* fix: pinterest and algolia cdk test cases (#1681)

* fix: pinterest cdk test cases

* fix: code review changes

* fix: code review changes

* fix: code review changes

* feat: router tranform refacor for destinations (batch - 1) (#1684)

* feat: router tranform refacor

* feat: router tranform refacor

* feat: code review changes

* feat: code review changes

* feat: router tranform refacor (#1685)

* feat: router tranform refacor for destinations (batch - 3) (#1686)

* feat: router tranform refacor

* feat: router tranform refactor

* feat: code review changes

* feat: refactor router transformer - 1 (#1687)

* feat: refactor-processRouterDest

* feat: refactor-processRouterDest

* feat: refactor-processRouterDest (#1688)

* feat: refactor-processRouterDest (#1689)

* feat: refactor router transformer - 4 (#1690)

* feat: refactor-processRouterDest

* feat: refactor-processRouterDest

* fix: incorrect usages of error types (#1691)

* fix: remove all usages of TRANSFORMER_METRIC

* fixcorrect usages of error types

* feat: add assertConfig default binding

* chore: remove unwanted arguments from function definition

* chore: remove unwanted null

* chore: simplified the syntax

* fix: set default status code

* chore: use optional chaining syntax

* fix: remove unwanted status code argument

* feat: destType removed (#1692)

* feat: refactor error types - review comments (#1697)

* fix: refactor error types

* fix: rt workflow to send stat tags in pinterest tag

* fix: router transform issues in marketo_static_list

* fix: restore router transform implementation

* fix: issues in router transformation across destinations

Co-authored-by: saikumarrs <saibattinoju@rudderstack.com>

* fix: final review issues (#1699)

* chore: add workspaceId as stat-tag (#1700)

Co-authored-by: Sai Sankeerth <sanpj2292@github.com>

* feat: add error handling for CDK v1 (#1698)

* fix: add parsed response in network error (#1704)

* fix[gaec]: revert destination response

* fix: authErrorCategory field in the response

Co-authored-by: saikumarrs <saibattinoju@rudderstack.com>

* fix: destinations network error responses (#1705)

* refactor: error handler for user deletion

* feat(destination): onboard discord

* chore: added testcases

* fix: comments addressed

* fix: comments addressed+1

* fix: comments addressed+2

* fix: comments addressed+3

* feat: add embed template with test cases

Co-authored-by: saikumarrs <saibattinoju@rudderstack.com>
Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
Co-authored-by: Krishna Chaitanya <chaithu.kitti@gmail.com>
Co-authored-by: Ujjwal Abhishek <63387036+ujjwal-ab@users.noreply.github.com>
Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com>
Co-authored-by: Sankeerth <sankeerth@rudderstack.com>
Co-authored-by: Sai Sankeerth <sanpj2292@github.com>
Co-authored-by: Anant <anant@rudderstack.com>
@github-actions github-actions bot deleted the feat.refactor-router-transform branch March 16, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koladilip koladilip koladilip approved these changes

@ujjwal-ab ujjwal-ab ujjwal-ab approved these changes

@mihir-4116 mihir-4116 mihir-4116 approved these changes

@sivashanmukh sivashanmukh Awaiting requested review from sivashanmukh

Assignees

@saikumarrs saikumarrs

Labels
Error refactor WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saikumarrs @koladilip @ujjwal-ab @mihir-4116