-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
And quietly breaks on Python 3 too... I give up |
Badges should be added to the README so that it's clear that it's a Python 3 project. |
apt-get install requirements that aren't listed in the README: With those requirements, confirmed working on Ubuntu Server 14.04 with Python 3.4.
Basically the README needs a serious update. At least now we have it all documented in this issue. If you are still having issues, run the tests ( |
Thanks! Will try again and let you know if I come unstuck again |
We should add the classifiers to |
Turned this into a PR (still in progress) |
Cool, have this up and running now with the extra dependencies mentioned here. Btw we're taking a shot at offering this up as a free service http://mathml.p16n.org/ Will do my best to keep it up to date with your releases, you know where to find me otherwise. |
Yeah! Great to see this in production somewhere. Thanks @calston, hope it wasn't too much of an issue to set up. We should probably also do a pypi or deb release to make it easier in the future. |
This is ready for review, seems those extra things is all that is needed to get it working. |
# mathml-to-image-service | ||
|
||
## Requirements | ||
- ``python == 3.4`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between single and double graves?
python == 3.4
vs. python == 3.4
I didn't know double graves worked. Single graves is used in Mastering Markdown for inline code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double graves allow you to have single graves within the code block. I use them by default for just in case, but I can change it if you think it's better to keep it to single graves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two graves are fine. Today I learnt.
Other than the small few comments, everything looks good to me 👍 Also awesome stuff seeing it out in the wild, @calston |
@zoidbergwill are you happy with the way the PR is now? Can I merge or do you want to change something else? |
Looks good to me. :) |
Python 3 requirement is not documented
This doesn't support Python 2.7.