Skip to content
This repository has been archived by the owner on Dec 24, 2019. It is now read-only.

Python 3 requirement is not documented #23

Merged
merged 4 commits into from
Oct 20, 2014
Merged

Conversation

rudigiesler
Copy link
Owner

This doesn't support Python 2.7.

@calston
Copy link
Author

calston commented Oct 19, 2014

And quietly breaks on Python 3 too... I give up

@rudigiesler
Copy link
Owner

Badges should be added to the README so that it's clear that it's a Python 3 project.

@rudigiesler
Copy link
Owner

apt-get install requirements that aren't listed in the README: pngcrush, imagemagick.

With those requirements, confirmed working on Ubuntu Server 14.04 with Python 3.4.

curl localhost:5000 -X POST -d "max_size=300" -d "image_format=gif" -d "quality=3" -d "mathml=<math display='block'><mrow><mrow><msub><mo>%26#x222b;</mo><mrow><mi>D</mi></mrow></msub><mrow><mo>(</mo><mo>%26#x2207;%26#x22c5;</mo><mi>F</mi><mo>)</mo></mrow><mi>d</mi><mrow><mi>V</mi></mrow></mrow><mo>=</mo><mrow><msub><mo>%26#x222b;</mo><mrow><mo>%26#x2202;</mo><mi>D</mi></mrow></msub><mrow><mtext>%26#x2009;</mtext><mi>F</mi><mo>%26#x22c5;</mo><mi>n</mi></mrow><mi>d</mi><mi>S</mi></mrow></mrow></math>"
{
  "url": "/static/e021894dfd8241f2a57d01a9424196b0.gif"
}

Basically the README needs a serious update. At least now we have it all documented in this issue.

If you are still having issues, run the tests (python -m unittest discover mathml_to_image_service) and paste the output here.

@calston
Copy link
Author

calston commented Oct 20, 2014

Thanks! Will try again and let you know if I come unstuck again

@zoidyzoidzoid
Copy link
Collaborator

We should add the classifiers to setup.py too.

@rudigiesler
Copy link
Owner

Turned this into a PR (still in progress)

@calston
Copy link
Author

calston commented Oct 20, 2014

Cool, have this up and running now with the extra dependencies mentioned here.

Btw we're taking a shot at offering this up as a free service http://mathml.p16n.org/

Will do my best to keep it up to date with your releases, you know where to find me otherwise.

@rudigiesler
Copy link
Owner

Yeah! Great to see this in production somewhere. Thanks @calston, hope it wasn't too much of an issue to set up. We should probably also do a pypi or deb release to make it easier in the future.

@rudigiesler
Copy link
Owner

This is ready for review, seems those extra things is all that is needed to get it working.

# mathml-to-image-service

## Requirements
- ``python == 3.4``
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between single and double graves?

python == 3.4 vs. python == 3.4

I didn't know double graves worked. Single graves is used in Mastering Markdown for inline code.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double graves allow you to have single graves within the code block. I use them by default for just in case, but I can change it if you think it's better to keep it to single graves.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two graves are fine. Today I learnt.

@zoidyzoidzoid
Copy link
Collaborator

Other than the small few comments, everything looks good to me 👍

Also awesome stuff seeing it out in the wild, @calston

@rudigiesler
Copy link
Owner

@zoidbergwill are you happy with the way the PR is now? Can I merge or do you want to change something else?

@zoidyzoidzoid
Copy link
Collaborator

Looks good to me. :)

rudigiesler pushed a commit that referenced this pull request Oct 20, 2014
Python 3 requirement is not documented
@rudigiesler rudigiesler merged commit abd946e into master Oct 20, 2014
@rudigiesler rudigiesler deleted the feature/update-readme branch October 20, 2014 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants