Fix Yell::Event::Options #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After defining <=> it is possible to get all comparison operators for "free" just by including the Comparable module. This is currently needed by rails 4.2.6 and above as seen here: rails/rails@a2a652a#diff-8a0607141c98298ea243209f7688f9e6R51
|
Can you check whether your change causes the CI to fail, plz. |
|
Failures are all occurring when running bundle, therefore not related to my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After defining <=> it is possible to get all comparison operators for
"free" just by including the Comparable module.
This is currently needed by rails 4.2.6 and above as seen here:
rails/rails@a2a652a#diff-8a0607141c98298ea243209f7688f9e6R51
This fixes #41