-
-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Windows desktop version of ruffle works terribly #2065
Comments
Not sure if its just a typing issue, but please make sure you are using r.e -g vs --graphics: both should work |
"-g dx12" works, just with the memory leak problem. "-g vulkan" won't work, ruffle will just pop up a white blank screen and exit after a moment.
thread 'main' panicked at 'assertion failed: This is what I got, by using the command "ruffle". If I use the command "ruffle -g vulkan", I got the exact same thing. (I'm aware there's a "note" in the output, but I don't know what to do with it.) |
The issue with Vulkan backend hanging/crashing is probably #1799. The desktop app is still quite early and designed to be a command line app; having a config file, UI, and installer is certainly on the roadmap (#575, #895). Could you post a link to the SWF you are trying to play so that we can look into the memory leak? Thanks for the report. |
@Herschel r.e memory issues |
Oh no. It's not related to any paricular SWF file. Here's the thing, I have about 200 SWF files on my computer. And I tried quite a few of them, all have memory leak problems when loaded with Windows desktop version of Ruffle. To further prove this, I downloaded a swf file stright from "Ruffle Web Demo"! I downloaded "Alien Hominid.swf" Opened it with Ruffle.exe, RAM usage is 13% and climbing... |
Thank you! I understand it happens in most SWF files, just trying to focus on a particular one so that I can reproduce the exact behavior and verify once it is fixed. |
Could you try on the latest nightly? There should be some improvement with memory usage, and the Nvidia vulkan hang should be fixed. Thank you! |
Tried. Here are the results...
Tried a few other swf files, results are similar: |
Wait a minute, just found another problem. |
On desktop, don't render while the window is minimized. In the wgpu backend, don't panic if swap chain fails to grab a texture. Instead recreate the swap chain and bail on the current frame. Fixes panic when minimizing with the wgpu vulkan backend (ruffle-rs#2065).
On desktop, don't render while the window is minimized. In the wgpu backend, don't panic if swap chain fails to grab a texture. Instead recreate the swap chain and bail on the current frame. Fixes panic when minimizing with the wgpu vulkan backend (#2065).
Tried the latest release (ruffle_nightly_2020_12_30_windows.zip), and things are getting better than the last time. DX12 mode still not looking good, RAM usage is 4% at the beginning (better than before), and keeps climbing +0.1~0.2% per second (same as before). And, Ruffle no longer crashes when I minimize the window. (BTW I'm not sure how low the RAM usage "should" be with Ruffle desktop app, though. Edit: Well, definitely need to optimize RAM usage more. |
What is this?? Is this a terrible joke or what? I spend 10 minutes or so to check that if you are a bot, because:
It's pointless to compare ruffle, or anything, to a player that basically don't work at all... It doesn't qualify as either a flash player or a video player. |
Ruffle sits at about 300 MB when playing Wasted Sky on my machine. That's quite a lot, but I haven't used Flash Player in a very long time so I don't know how it compares. I have quite a bit of stuff in the background. 82% of my memory is being used according to the Windows task manager (mostly by Edge, which uses about 200 more MB than Chrome when in the foreground lol). I've got 8 GB of memory in this laptop. I could definitely see the memory leaks when using the DX12 backend. I got scared so I ended it myself. |
I tried two versions of ruffle, the "https://ruffle.rs/demo/" version (using Firefox), and the "ruffle_nightly_2020_xx_xx_windows.zip" version. The Windows version is terrible in many ways.
First, I'll report the most frustrating thing: Memory leak. The Windows version could use like 30% RAM (I have 16GB RAM) when opening a swf file. while using the web demo, it only uses about 0.1%.
Sometimes the Windows version will even use 50% RAM and climbing, making my whole system freeze for a while, before it finally crashes.
This made me too scared to even test the Windows version more!
Second, I have difficulties setting up the player.
I expect to just double click a .swf file, and Windows will automatically open it with "ruffle.exe". (Just like what I did with "flashplayer_25_sa_debug.exe".)
But that won't open correctly. I can't open any swf file directly with ruffle.exe.
I need a launch parameter "--graphics dx12". But then how do I config Windows to automatically add that launch parameter? There's no way I can do that.
I ended up creating a shortcut of "ruffle.exe", adding the launch parameter in the shortcut's properties. To open any file, I have to drag the swf file to the shortcut, to open it.
What should happen is that, ruffle.exe reads a "settings.ini" file when it launches. So I can set the launch parameters in that ".ini" file.
And if there's no "settings.ini" file, create one with default settings. (Don't just include a ini file in the release zips, so updating Ruffle won't overwrite the existing ini file and reset settings.)
Meanwhile...
The web demo version works fine. Just like the adobe flash player (lot of swf files I tested didn't work correctly, of course, but at least no serious problems, no freezing my system, no 70% RAM usage, and most swf files will at least show a first screen correctly).
(Before you ask, I tested Ruffle desktop version on 3 different nightly builds, during this time period I upgraded my graphics driver twice. So I can confirm this is a persistent problem.)
The text was updated successfully, but these errors were encountered: