avm2: Implement XML settings & correct the XMLDocument implementation #12465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evilpie
reviewed
Jul 31, 2023
evilpie
reviewed
Jul 31, 2023
|
Very cool. LGTM |
evilpie
reviewed
Jul 31, 2023
Dinnerbone
force-pushed
the
xml_document
branch
3 times, most recently
from
20c86fa
to
c845ab2
Compare
… add appropriate properties to XML class
Dinnerbone
force-pushed
the
xml_document
branch
from
c845ab2
to
499ca95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11289 and makes a bunch of games playable