Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump image to v0.25, without the dxt feature #15634

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

torokati44
Copy link
Member

I hope some visual tests will fail on this, at least on Windows.
To be fixed by an alternative implementation based on https://github.com/jansol/texpresso, as recommended.

@torokati44
Copy link
Member Author

Uuuuhm. Huhh. How does this still work, @Aaron1011 ? 🤔
Do we simply not have a visual test for DXT-compressed textures?
I have no idea how ATF actually works together with the different algorithms... :/

@Aaron1011
Copy link
Member

I added the dxt feature early on when working on compressed alpha support, but we don't actually use it - we produce a TIFF image from the jpegxr crate, and then decode that using the image crate.

@torokati44 torokati44 marked this pull request as ready for review March 18, 2024 22:58
@torokati44
Copy link
Member Author

Oooh, I see. Thanks for the explanation!
So we're actually always taking the "compatibility fallback" option out of the ATF, and pre-decompress it on the CPU for the sake of portability, instead of making use of the other GPU-friendly compressed alternatives in there?

@torokati44 torokati44 merged commit d9f17da into ruffle-rs:master Mar 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants