core: Render yellow rectangular highlight on keyboard focus #15717
Conversation
|
It seems that I accidentally improved Ruffle compatibility regarding the Look at its left eye 🧐 (other differences result from the fact that elements are animated and I picked a random frame)
|
|
Plus the little rectangle on the bottom left is now rotated as it should be. The little block under its chin looks more different though... 🤔 |
Ohh you shouldn't really look at that. Those elements are animated and I picked a random frame (I should've mentioned that!) Regarding the pixel-perfect first-frame render:
|
|
Ah, I see! Then perhaps we should compare more frames, to also test the animation? Now that there is support for that... :) Not in scope of this PR of course. |
kjarosh
force-pushed
the
tab-ordering-highlight
branch
5 times, most recently
from
bae7965
to
46df652
Compare
kjarosh
force-pushed
the
tab-ordering-highlight
branch
2 times, most recently
from
8fd032e
to
97398a2
Compare
danielhjacobs
added
the
waiting-on-review
kjarosh
force-pushed
the
tab-ordering-highlight
branch
from
97398a2
to
1d28b18
Compare
| } | ||
|
|
||
| let bounds = focus.world_bounds().grow(-Self::HIGHLIGHT_WIDTH / 2); | ||
| let mut drawing = Drawing::new(); |
There was a problem hiding this comment.
Using Drawing for this is going to be a little expensive on the rendering side, but realistically this isn't going to be hit enough to be noticed (I hope?)
Ideally we have a draw command that's "draw box outline" later, and let the render backend optimise that. It can make it screen-pixel perfect too, which would be nice.
Not something you need to change for this PR - just a comment!
kjarosh
force-pushed
the
tab-ordering-highlight
branch
from
1d28b18
to
7fbae4f
Compare
This patch implements rendering of the yellow rectangle around a focused element after pressing Tab. Focus tracker which is responsible for keeping track of the current focus is now also responsible for keeping track of the highlight and rendering thereof.
kjarosh
force-pushed
the
tab-ordering-highlight
branch
from
7fbae4f
to
ebef447
Compare
Lord-McSweeney
removed
the
waiting-on-review
Related to #5443.
This patch implements rendering of the yellow rectangle around a focused element after pressing Tab.