core: Ignore non-tabbable objects from tab ordering #15864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
force-pushed
the
tabbable
branch
3 times, most recently
from
c0508b4
to
8590aa6
Compare
Dinnerbone
approved these changes
Apr 4, 2024
|
"tabbable" is a bit funky but I'll allow it :D |
These objects include: * invisible objects along with their children, * non-editable text fields. The method `is_tab_enabled` is renamed to `is_tabbable`, as it no longer represents the `tabEnabled` property value, but also incorporates other logic.
This test verifies what objects are tabbable by default and after setting tabEnable & tabIndex. This test includes: * invisible objects, * objects with 0x0 size, * object outside of visible window bound, * objects within invisible containers, * non-selectable texts, * non-editable texts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5443, #15851.
These objects include:
The method
is_tab_enabledis renamed tois_tabbable, as it no longer represents thetabEnabledproperty value, but also incorporates other logic.This PR significantly improves the tab behavior and automatic ordering.