Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Ignore non-tabbable objects from tab ordering #15864

Merged
merged 2 commits into from
Apr 4, 2024
Merged

core: Ignore non-tabbable objects from tab ordering #15864

merged 2 commits into from
Apr 4, 2024

Commits on Apr 4, 2024

  1. core: Ignore non-tabbable objects from tab ordering 

    These objects include:
* invisible objects along with their children,
* non-editable text fields.

The method `is_tab_enabled` is renamed to `is_tabbable`, as it no
longer represents the `tabEnabled` property value, but also
incorporates other logic.
    @kjarosh @Dinnerbone
    kjarosh authored and Dinnerbone committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    9b682f4 View commit details
    Browse the repository at this point in the history

  2. tests: Add tab_ordering_tabbable test 

    This test verifies what objects are tabbable by default
and after setting tabEnable & tabIndex. This test includes:
* invisible objects,
* objects with 0x0 size,
* object outside of visible window bound,
* objects within invisible containers,
* non-selectable texts,
* non-editable texts.
    @kjarosh @Dinnerbone
    kjarosh authored and Dinnerbone committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    6576ce2 View commit details
    Browse the repository at this point in the history