Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BucketSelector aggregation #1554

Merged
merged 11 commits into from Dec 17, 2018

Conversation

@maltehuebner
Copy link
Contributor

@maltehuebner maltehuebner commented Dec 11, 2018

I added the BucketSelector aggregation and wrote a small test.

@maltehuebner maltehuebner changed the title Added BucketSelector aggregation and test Added BucketSelector aggregation Dec 11, 2018
* master:
  update to ES 6.5.2 and to LATEST PHP 7.3 official relase (#1552)
  Prepare for 6.1.0 release (#1547)
  test connection error (#1546)
  Add php73 support and Xdebug (#1545)
lib/Elastica/Aggregation/BucketSelector.php Outdated Show resolved Hide resolved
lib/Elastica/Aggregation/BucketSelector.php Outdated Show resolved Hide resolved
lib/Elastica/Aggregation/BucketSelector.php Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@maltehuebner
Copy link
Contributor Author

@maltehuebner maltehuebner commented Dec 13, 2018

I hope I now resolved all your issues :)

@maltehuebner
Copy link
Contributor Author

@maltehuebner maltehuebner commented Dec 13, 2018

Are we using return types and scalar parameter types as ^7.0 is required in composer.json? I just stumpled upon #1558 and would like to add them into my pull request.

@p365labs
Copy link
Collaborator

@p365labs p365labs commented Dec 13, 2018

@maltehuebner yep there will be a massive refactoring on that, so if u would like to update your PR you are welcome :)

👍 for the PR for me!

CHANGELOG.md Outdated Show resolved Hide resolved
test/Elastica/Aggregation/BucketSelectorTest.php Outdated Show resolved Hide resolved
lib/Elastica/Aggregation/BucketSelector.php Outdated Show resolved Hide resolved
@p365labs
Copy link
Collaborator

@p365labs p365labs commented Dec 17, 2018

@ruflin for me it's ok to be merged

@ruflin
Copy link
Owner

@ruflin ruflin commented Dec 17, 2018

@p365labs Changelog still looks "interesting" to me?

@p365labs
Copy link
Collaborator

@p365labs p365labs commented Dec 17, 2018

@ruflin yep u're right

Added BucketSelector aggregation #1554

@maltehuebner is still under a release and should be move to unreleased under "Added"

@p365labs
Copy link
Collaborator

@p365labs p365labs commented Dec 17, 2018

@ruflin now to me seems ok, what about u ?

@ruflin
ruflin approved these changes Dec 17, 2018
@p365labs p365labs merged commit 83d1a61 into ruflin:master Dec 17, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@maltehuebner maltehuebner deleted the maltehuebner:bucketselector-aggregation branch Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants