Sanitize host name for AWS requests before signing in AWSAuthV4 trans… #2090
Conversation
jhuebner79
force-pushed
the
fix-issue-1777-trailing-dot-during-request-signing
branch
2 times, most recently
from
0616fed
to
ea5d6fb
Compare
jhuebner79
force-pushed
the
fix-issue-1777-trailing-dot-during-request-signing
branch
from
ac171b2
to
b376ef5
Compare
jhuebner79
force-pushed
the
fix-issue-1777-trailing-dot-during-request-signing
branch
from
b376ef5
to
54b5234
Compare
|
The change LGTM. Thanks @jhuebner79 . As I don't have any AWS setup and it is not part of the test suite, I don't really have a way to test this. Did you by chance run this code with one of your setups? |
Yes, we were able to reference my branch in our |
jhuebner79
force-pushed
the
fix-issue-1777-trailing-dot-during-request-signing
branch
from
54b5234
to
630b3f2
Compare
|
@franmomu I force pushed the code I suggested earlier, and your suggestion as well |
|
oh no, the local tests are not running successfully anymore.. hang on please |
jhuebner79
force-pushed
the
fix-issue-1777-trailing-dot-during-request-signing
branch
from
630b3f2
to
d0905bf
Compare
|
Found it - looks good locally now (did another force push) |
jhuebner79
force-pushed
the
fix-issue-1777-trailing-dot-during-request-signing
branch
from
d0905bf
to
bcb873c
Compare
jhuebner79
force-pushed
the
fix-issue-1777-trailing-dot-during-request-signing
branch
from
bcb873c
to
857717a
Compare
| @@ -135,3 +135,7 @@ parameters: | |||
| count: 1 | |||
| path: tests/SnapshotTest.php | |||
|
|
|||
| - | |||
There was a problem hiding this comment.
Not sure if this is the right indentation level
There was a problem hiding this comment.
Thanks, I'll check
There was a problem hiding this comment.
hmm, basically I copied lines 28-31 and did not change indentation at all 🤔
It's the same like in the whole file, four spaces everywhere..
There was a problem hiding this comment.
@thePanz anything I can do here?
|
@jhuebner79 I will check the indentation later, would you be able to provide some tests covering the added lines? |
We honestly have no idea why the added lines are not picked up by codecov, I'd be very happy if someone who's more familiar with the project could help us a bit here. |
|
I've created #2113 that should help with this (it adds a job to test with lowest dependencies) |
|
Lets get this moving again. I resolved the Changelog conflict which triggered another CI run and got the PR from @franmomu merged. @jhuebner79 @thePanz What are the other things we still need? |
|
@ruflin thanks for that! I still don't know why codecov is not happy or what I can do about it, but I think I would need to rebase to current master? |
| $client = $this->_getClient($config); | ||
|
|
||
| try { | ||
| $client->request('_stats'); |
There was a problem hiding this comment.
Is this executing all the new code? Maybe that is the issue?
There was a problem hiding this comment.
We're able to have a look later on today or tomorrow.
There was a problem hiding this comment.
So, we hacked the make targets and the Dockerfile for elastica_php to be able to generate phpunit code coverage reports, and it doesn't look too bad there.. see attached screenshot. 🤔
jhuebner79
force-pushed
the
fix-issue-1777-trailing-dot-during-request-signing
branch
from
6e93bae
to
ea3f4b6
Compare
|
I suggest we just leave the bots to themself and agree that codecov is fine even thought it shows it isn't? Any objections? |
|
By reacting with the heart smiley I meant "not from my side", of course :) |
|
I resolved a changelog conflict to get this mergeable. @thePanz As you were also involved in this PR, ok for you if we get this in? |
|
I merged this PR now. If we see issues, we can always revert. Anyone using / testing this, please report back. |
jhuebner79
deleted the
fix-issue-1777-trailing-dot-during-request-signing
branch
...port