Test lowest dependencies in CI #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franmomu
force-pushed
the
use_ramsey_composer_install
branch
from
4be1c35
to
defd658
Compare
franmomu
force-pushed
the
use_ramsey_composer_install
branch
from
defd658
to
f08af92
Compare
ruflin
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
I quite like this addition as we keep knowing what the minimal version of ES is that has all the features also in Elastica. It doesn't mean you can't use Elastica with Elasticsearch 7.0 but there are functions that only work with never version (which I think should be expected).
One thought I have around versioning is if we add features only supported in 7.15, should we also increment the Elastica version to this number?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
ramsey/composer-installallows us to simplify the CI jobs removing the cache steps for composer.This PR adds a job to run our tests using the lowest set of dependencies, while doing so, some tests failed because the
OpenPointInTimeclass did not exist, that is because it was added inelasticsearch/elasticsearch7.10so I bumped the library to that version.