New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first initial implementation of Emoji search in address bar #5
Conversation
(called omnibar)
Upstream declined change, but in the future a whole new API could come. That means, for now, we could only adjust this to copy the emoji to the clipboard, at least. (after we get |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
So the search now works and correctly falls back to copying the emoji, if it has the permission.
TODO:
|
This comment has been minimized.
This comment has been minimized.
So we can now request permissions properly and ask the user.
Now only hides the active message in case of rejection.
localizeawesome-emoji-picker/src/options/modules/PermissionRequest.js Lines 284 to 289 in b62e0d6
This comment was generated by todo based on a
|
And add TODO
possibly depending on TinyWebEx/AutomaticSettings#10 |
. cancel permission prompt already shownawesome-emoji-picker/src/options/modules/CustomOptionTriggers.js Lines 318 to 323 in 4852016
This comment was generated by todo based on a
|
generalize in AutomaticSettingsawesome-emoji-picker/src/options/modules/CustomOptionTriggers.js Lines 299 to 304 in e3e7337
This comment was generated by todo based on a
|
Ready to merge. Possibly only TODO:
|
Note: If a solution for opening the popup or so is found, passing the search term to the popup should be quite easily possible: missive/emoji-mart#266 (comment) |
(called omnibar)
Edit: Fixes #33
Blocked (?) by: