Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first initial implementation of Emoji search in address bar #5

Merged
merged 31 commits into from Sep 15, 2019

Conversation

rugk
Copy link
Owner

@rugk rugk commented Apr 5, 2019

(called omnibar)

Edit: Fixes #33

Blocked (?) by:

@rugk rugk added enhancement New feature or request blocked Cannot be resolved, because we need to wait for something else to be resolved first. labels Apr 5, 2019
@rugk
Copy link
Owner Author

rugk commented May 2, 2019

Upstream declined change, but in the future a whole new API could come.

That means, for now, we could only adjust this to copy the emoji to the clipboard, at least. (after we get clipboardWrite permission)

@rugk rugk removed the blocked Cannot be resolved, because we need to wait for something else to be resolved first. label May 2, 2019
@todo

This comment has been minimized.

@todo

This comment has been minimized.

rugk added 3 commits May 28, 2019 09:52
So the search now works and correctly falls back to copying the emoji, if it has the permission.
@rugk
Copy link
Owner Author

rugk commented May 30, 2019

TODO:

  • add options (opt-in) for emoji bar search
  • request clipboardWrite permission when enabled
  • make logic independent from other settings in add-on (EmojiInteraction)
  • (optional) search for emoji on emojipedia instead of copying it

@todo

This comment has been minimized.

@todo
Copy link

todo bot commented Jun 5, 2019

localize

CommonMessages.showError("Requesting permission failed.", true); // TODO: localize
break;
case false:
// CommonMessages.showError("This feature cannot be used without the permission.", true);
break;
default:


This comment was generated by todo based on a TODO comment in b62e0d6 in #5. cc @rugk.

And add TODO
@todo
Copy link

todo bot commented Jun 5, 2019

revert setting to previous state

// TODO: revert setting to previous state
});
}
return Promise.resolve();
}


This comment was generated by todo based on a TODO comment in 4556c11 in #5. cc @rugk.

@rugk
Copy link
Owner Author

rugk commented Jun 6, 2019

possibly depending on TinyWebEx/AutomaticSettings#10

@rugk rugk added this to the 1.2 milestone Jun 22, 2019
@todo
Copy link

todo bot commented Jul 8, 2019

. cancel permission prompt already shown

debugger; // TODO. cancel permission prompt already shown
}
return Promise.resolve();
}


This comment was generated by todo based on a TODO comment in 4852016 in #5. cc @rugk.

@todo
Copy link

todo bot commented Sep 13, 2019

generalize in AutomaticSettings

// TODO: generalize in AutomaticSettings
const isEnabled = document.getElementById("omnibarIntegration").checked;
const newOptionValue = {
enabled: isEnabled
};


This comment was generated by todo based on a TODO comment in e3e7337 in #5. cc @rugk.

@rugk
Copy link
Owner Author

rugk commented Sep 13, 2019

Ready to merge.

Possibly only TODO:

  • split PermissionRequest module out of this. It's actually quite nice.

@rugk rugk merged commit a63f6b0 into master Sep 15, 2019
This was referenced Sep 15, 2019
@rugk rugk deleted the omnibox branch September 15, 2019 14:20
@rugk rugk added this to In progress in Address bar search feature via automation Sep 15, 2019
@rugk rugk moved this from In progress to Done in Address bar search feature Sep 15, 2019
@rugk rugk mentioned this pull request Jan 15, 2020
rugk pushed a commit that referenced this pull request Nov 8, 2020
@rugk
Copy link
Owner Author

rugk commented May 13, 2022

Note: If a solution for opening the popup or so is found, passing the search term to the popup should be quite easily possible: missive/emoji-mart#266 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Refactoring: Create single module EmojiInteraction for selection action
1 participant