Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple instances support #28

Open
regagain opened this issue May 19, 2019 · 7 comments
Open

Multiple instances support #28

regagain opened this issue May 19, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@regagain
Copy link

Thank you for this great add-on!

It would be great to have support for multiple instances. I guess it would require some kind of UI that lets the user choose which one of the their instances they want to use every time there's an interaction. What do you think?

@rugk rugk added the enhancement New feature or request label May 19, 2019
@rugk
Copy link
Owner

rugk commented May 19, 2019

One important question would be:

  • Is it enough if you have a popup or so, where you could select which account you want to currently redirect to?
  • or should it be possible to chose this each time an interaction/follow request appears?

@regagain
Copy link
Author

regagain commented May 19, 2019

Is it enough if you have a popup or so, where you could select which account you want to currently redirect to?

I think this would be enough!

@rugk
Copy link
Owner

rugk commented May 19, 2019

Okay, maybe I'll wait for some more opinions.

Because, actually, the "choose each time" mode may be easier to implement… 😆

@regagain
Copy link
Author

Both options are fine with me tbh :)

@2rs2ts
Copy link

2rs2ts commented Nov 23, 2022

I would like to suggest that, if it could support firefox containers, a workflow of one account per container (which is what I do, for the most part) would prevent the need for a mandatory "ask each time" flow. Just some food for thought, though!

@rugk
Copy link
Owner

rugk commented Nov 30, 2022

Indeed, that is a great idea. The API doc for that is https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/contextualIdentities and the permission could (and should) be optional and be requested when a setting is enabled via the PermissionRequest lib.

Note also when we have the tab, we can then retrieve the contextual (cookie store) ID of that to find out what context we currently have: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs/Tab#cookiestoreid

Example: https://github.com/mdn/webextensions-examples/tree/master/contextual-identities

Note any more design help or implementation help is certainly welcome here.

@testman42
Copy link

I'm happy to see progress being made about this, as #92 is an issue that I encountered as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants