Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nl translations #118

Merged
merged 2 commits into from Jan 1, 2024
Merged

Add nl translations #118

merged 2 commits into from Jan 1, 2024

Conversation

hugo-vrijswijk
Copy link
Contributor

  • Add Dutch translations
  • Rename links to main branch instead of master

I didn't add any translations in assets/texts as not all currently supported languages are there and I wasn't sure if I should add them. I also wasn't bothered to translate all the changelogs 😅

@rugk
Copy link
Owner

rugk commented Oct 6, 2023

Hi @hugo-vrijswijk,
first of all, thanks for your first contribution to this project! 🎉 👍 🏅
I hope you'll like this project and enjoy hacking on it… 😃

I didn't add any translations in assets/texts as not all currently supported languages are there and I wasn't sure if I should add them. I also wasn't bothered to translate all the changelogs 😅

Yeah, you can do it, I will upload it to AMO when the next release happens. However, e.g. you do not need to translate old changelog entries, the most recent one is enough or maybe none at all. Other text parts are more visible anyway.

Please subscribe to #40 to get notified for new updates on translations etc. 😃

BTW note if you want you can also write the Changelog entry already, just copy an existing one as explained as a side-note here.

For more information, please see the MDN guide on how to localize WebExtensions and our internationalization (i18n) guide.

Copy link
Owner

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot especially also for the additional work in correcting the branch name!

CONTRIBUTING.md Show resolved Hide resolved
@rugk rugk merged commit e6ce0d2 into rugk:main Jan 1, 2024
@rugk rugk added this to the v2.2 milestone Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants