Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/Use kjua-svg version by @werthdavid for testing #2

Merged
merged 4 commits into from
Jul 26, 2020
Merged

Add/Use kjua-svg version by @werthdavid for testing #2

merged 4 commits into from
Jul 26, 2020

Conversation

rugk
Copy link
Owner

@rugk rugk commented Jul 30, 2019 •
edited
Loading

@todo
Copy link

todo bot commented Jul 30, 2019

should it reject invalid values?

qr-code-libs-test/modules/QrLib/kjua-svg.js

Lines 102 to 107 in 69e6d28

// TODO: should it reject invalid values?
kjuaOptions[tag] = value;
}
/**

This comment was generated by todo based on a TODO comment in 69e6d28 in #2. cc @rugk.

@rugk rugk mentioned this pull request Jul 30, 2019
Closed
@rugk rugk merged commit 63c4c22 into master Jul 26, 2020
@rugk rugk deleted the kjua-svg-test branch July 26, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rugk