Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thunderbird download button and badges to README #59

Closed
1 of 3 tasks
tdulcet opened this issue Aug 13, 2021 · 9 comments · Fixed by #67
Closed
1 of 3 tasks

Add Thunderbird download button and badges to README #59

tdulcet opened this issue Aug 13, 2021 · 9 comments · Fixed by #67
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request Thunderbird Thunderbird-only issues
Milestone

Comments

@tdulcet
Copy link
Collaborator

tdulcet commented Aug 13, 2021

Add Thunderbird download button and badges to README: https://addons.thunderbird.net/en-US/thunderbird/addon/unicodify-text-transformer/ Note that TB does not currently track the number of downloads for add-ons, just the number of users. (see thunderbird/addons-server#80).

We also should consider creating a separate ATN description files for Thunderbird instead of reusing the existing AMO description files. I had to manually make several tweaks and remove irreverent information that does not apply to Thunderbird. In addition, most of the Unicode fonts and emojis are not supported on ATN, so I also had to manually remove those as well.

@rugk - I am guessing you may also want to update your AddonTemplate repository.

To do:

  • Add Thunderbird download button to README
  • Add Thunderbird badges to top of README
  • Add separate summary and description files for ATN (done for English in Added separate files for ATN #63)
@tdulcet tdulcet added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 13, 2021
@rugk rugk added this to the 1.0 milestone Aug 14, 2021
@rugk
Copy link
Owner

rugk commented Aug 14, 2021

Oh sorry totally missed that and created #59, yes you're right of course.Feel free to adjust that here.

We also should consider creating a separate ATN description files for Thunderbird instead of reusing the existing AMO description files. I had to manually make several tweaks and remove irreverent information that does not apply to Thunderbird.

Yes, you're right. Just make a PR with the new file.

In addition, most of the Unicode fonts and emojis are not supported on ATN, so I also had to manually remove those as well.

Hmm is not this a system/OS/browser level thing. AMO also does not render emojis in any way, they just let it render by the browser/OS. You might need to try different browsers or so (try https://www.browserstack.com/) to be sure here…

@rugk - I am guessing you may also want to update your AddonTemplate repository.

Let's first merge this here, it's not clear whether any other add-on will be compatible with Thunderbird in the future.

@tdulcet
Copy link
Collaborator Author

tdulcet commented Aug 14, 2021

The Firefox download badge can nowadays be used/get from https://extensionworkshop.com/documentation/publish/promoting-your-extension/, I don't know where the Thunderbird badge might come from/be hosted on. Maybe @tdulcet you know more. 🙂

I am not sure… The Thunderbird developer documentation is here: https://developer.thunderbird.net/add-ons/about-add-ons, but I do not see anything related to a download button.

Yes, you're right. Just make a PR with the new file.

OK, will do.

Hmm is not this a system/OS/browser level thing. AMO also does not render emojis in any way, they just let it render by the browser/OS.

Oh, the ATN UI does not let me add most of the Unicode fonts or emojis. If I try, I just get a spinning timer forever. I tried using both the actual emojis (e.g. 😊) and the HTML entities (e.g. 😊). You are of course welcome to try yourself and maybe you will have better luck…

@rugk
Copy link
Owner

rugk commented Aug 14, 2021

Oh, the ATN UI does not let me add most of the Unicode fonts or emojis. If I try, I just get a spinning timer forever.

Rather sounds as a bug at ATN's side…

@rugk
Copy link
Owner

rugk commented Aug 17, 2021

Okay, asked for that button on https://discourse.mozilla.org/t/get-add-on-download-badge-button-image/84631?u=rugkx

Oh, the ATN UI does not let me add most of the Unicode fonts or emojis. If I try, I just get a spinning timer forever.
Rather sounds as a bug at ATN's side…

As for that, do you want to report a bug @tdulcet?

@tdulcet
Copy link
Collaborator Author

tdulcet commented Aug 17, 2021

As for that, do you want to report a bug @tdulcet?

OK, I created thunderbird/addons-server#170. I thought the Awesome Emoij Picker was a better example of the problem, so I used that for the issue.

@tdulcet
Copy link
Collaborator Author

tdulcet commented Aug 23, 2021

Okay, asked for that button on https://discourse.mozilla.org/t/get-add-on-download-badge-button-image/84631?u=rugkx

If we do not get a response, we could also ask on the Thunderbird Topicbox: https://thunderbird.topicbox.com/groups/addons or create an issue here: https://github.com/thundernest/developer-docs/issues

@rugk
Copy link
Owner

rugk commented Aug 24, 2021

As far as I see, it is safe to say "we did not got a response" by now… 😅

So yeah, thanks for finding more support "forums"! Cross-posted it there, everywhere:

@tdulcet
Copy link
Collaborator Author

tdulcet commented Sep 7, 2021

@rugk - It looks like we got a button: https://github.com/thundernest/addon-developer-support/blob/master/images/get-the-addon.svg

@rugk
Copy link
Owner

rugk commented Sep 7, 2021

Ah thanks, forgot that. Created a PR in #67.
Opened badges/shields#6994 for the badge request, but IMHO we can then close this issue if the PR is merged, because these badges are not that important.

The download button is more important here. 🙂

@rugk rugk closed this as completed in #67 Sep 9, 2021
@rugk rugk added the Thunderbird Thunderbird-only issues label Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request Thunderbird Thunderbird-only issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants