Disable autocorrect feature by default #72
Conversation
tdulcet
force-pushed
the
disable-autocorrect
branch
from
e4f7d4b
to
5479a94
Compare
Co-authored-by: rugk <rugk+git@posteo.de>
| @@ -40,7 +24,8 @@ function notification(title, message) { | |||
| */ | |||
| function fallback(text, fieldId) { | |||
| navigator.clipboard.writeText(text); | |||
| notification(`📋 Press ${pasteSymbol}-V`, `Add-ons in Thunderbird are currently unable to access the “${fieldId.startsWith("compose") ? fieldId.slice("compose".length) : fieldId}” field directly, so the transformed text has been copied to your clipboard.\nPlease press ${pasteSymbol}-V to do the transformation.`); | |||
| // This will need to be localized | |||
There was a problem hiding this comment.
Feel free to add todos as real TODO comments. AFAIK I also I had a not or so which would notify you in this or if you have such a one.
There was a problem hiding this comment.
OK, will do... I will leave the localization to you.
|
Localized: |
Tested with Awesome Emoji Picker manually And Unicodify, needed for rugk/unicodify#72
|
So needed some CSS adjustments: TinyWebEx/CommonCss#2 looks good now with a proper warning message: |
|
I also simply removed the Also it was not really a great UI to have that default Firefox dialog somewhere in here, and worse, if you showed that popup multiple times, it tried to show a "do not disturb" checkbox, but the checkbox is not there… 😅 😅
|
|
requesting review from @tdulcet (cannot do via GitHub as you've opened this PR 😅 ) |
There was a problem hiding this comment.
Thanks for taking care of the localization! Also, thanks for adding the proper warning message, I did not realize we could do that. Anyway, it looks good, just a minor change needed...
It's not that bad. It does not kill the computer or have other non-reversible effects after all.
It does of course completely break Twitter, Facebook and likely other websites and I did not want to get a bunch of negative reviews. However, I agree that the UI was not the best, particularly because it does not currently work on Thunderbird (Bug 1780977) or Chromium (Bug 476350), so I am fine with removing it.
and worse, if you showed that popup multiple times, it tried to show a "do not disturb" checkbox, but the checkbox is not there… 😅 😅
Ha, it looks like you found a Firefox bug. I am able to reproduce it as well.
Edit: I think you forgot to delete the src/common/variables.css file when you added your CommonCSS module.
Co-authored-by: Teal Dulcet <tdulcet@gmail.com>
BTW, if you want to report that bug, feel free… 🙃 |
C,F,Qandqsuperscript characters that were included with Unicode 14 in 2021.+,-,=,(and)superscript characters.I believe this should finally allow us release v1.0. The Unicode autocorrection feature could then be enabled in a future release, such as v2.0.