Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new WebExtension API modifying about:config #41

Merged
merged 16 commits into from
Dec 7, 2021
Merged

Implement new WebExtension API modifying about:config #41

merged 16 commits into from
Dec 7, 2021

Conversation

rugk
Copy link
Owner

@rugk rugk commented Nov 28, 2021

The new API can modify the browser settings via about:config
i.e. overrideContentColorScheme, which basically is exactly the API to make this add-on work properly.

Fixes #5

@rugk
Implement new WebExtension API modifying about:config
6106115 
The new API can modify the browser settings via `about:config`
i.e. `overrideContentColorScheme`, which basically is exactly the API to make this add-on work properly.

Fixes #5
@rugk
Remove all content scripts
8826e60 
They are not needed anymore.
@rugk
Merge branch 'master' into newSettingApi
2265efd
@rugk
Remove more dead code now
ca2f259
@rugk
Update and include new CommonCss submodule
b0201d1 
This makes sure the dark mode is properly shown on the settings page.
@rugk
Remove now fixed light forcing statement in options page
a18744f
@rugk
Add simple config to resolve paths with VsCode
dee1179
@rugk
Update dependencies
890b027
@rugk
Refactor value setting and options page
770175c 
* removes now not needed options
* fix a badge text error thrown due to invalid type being passed
@todo
Copy link

todo bot commented Nov 29, 2021

implement optional syncing!

website-dark-mode-switcher/src/common/modules/DarkModeLogic.js

Lines 41 to 46 in 770175c

// TODO: implement optional syncing!
// const shouldBeSynced = await AddonSettings.get("shouldBeSynced");
// if (shouldBeSynced) {
// const currentBrowserSetting = (await browser.browserSettings.overrideContentColorScheme.get({})).value;
// const syncedSetting = await AddonSettings.get("fakedColorStatus");

This comment was generated by todo based on a TODO comment in 770175c in #41. cc @rugk.

@rugk
Correctly show status change on setting page
1ab3c6b 
Adds a trigger, so changes from somewhere else like the action button do work too.
@rugk
Implement old data upgrade and options for new possibilities
ce86412
@rugk
Refactor value setting
afe590b 
* removes now not needed options
* fix a badge text error thrown due to invalid type being passed
@rugk
Make buttons for toggeling the two states
cfeb8cc
@rugk
Add changelog
3263d51
@rugk
Bump version to v2.0
dd15fec
@rugk rugk marked this pull request as ready for review December 7, 2021 23:02
@rugk rugk linked an issue Dec 7, 2021 that may be closed by this pull request
Injected media query always overrides other media queries that should take precedence #16
Closed
@rugk
Copy link
Owner Author

rugk commented Dec 7, 2021

Release-Test done

@rugk rugk linked an issue Dec 7, 2021 that may be closed by this pull request
https://ar.al/ Vimeo Embed Inverted #39
Closed
This was linked to issues Dec 7, 2021
Corss-origin stylesheets without crossorigin="anonymous" attribute not supported (e.g. Hardware.info) #31
Closed
Support for picture/source/@media queries #24
Closed
Plugin not Work on Prefetch Stylesheet #17
Closed
Does not work on initial page load with NoScript #23
Closed
Bootstrap 5 Dark Mode has incorrect gradient/fades applied #40
Closed
@rugk rugk merged commit 9b5bf82 into master Dec 7, 2021
@todo todo bot mentioned this pull request Dec 7, 2021
Open
@rugk rugk deleted the newSettingApi branch December 8, 2021 00:05
@rugk rugk mentioned this pull request Dec 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@rugk