Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fixes and features #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sethfaulkner
Copy link

My team supports a private project and has run hundreds of json files through your project. It works very well for our purposes, with some minor fixes and features added. What is addressed in this pull request is:

  • Fix to min_diff method, preventing it from finding actual minimum
  • Added None check in transform method, preventing crash
  • Added a 'percent_diff' rule to allow the project to match on slightly different values (some of our outputs are not always exact)
  • Added the float comparison logic to the '_list_content_diff' method to be able apply rules to them

One thing to note is that I believe there is a slight problem with the list compare logic. It will check length and that each element exists but would be defeated by the case [1,2,2] == [1,1,2].

Thanks for all the hard work on this! I hope you consider this PR.

@rugleb
Copy link
Owner

rugleb commented May 19, 2024

Hi! Thx for contribution.
Can u split u PR for a few different PRs? 1 feature/fix = 1 PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants