Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove methods that depend on EventContent::from_parts #1439

Closed
wants to merge 2 commits into from

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Jan 4, 2023

Even if we can't remove from_parts, they can depend on the type implementing Deserialize instead.


Preview Removed

@zecakeh zecakeh requested a review from jplatte January 4, 2023 17:20
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are keeping from_parts, maybe keep deserialize_content and adjust the docs to say "Use Raw::deserialize_as or Raw::deserialize_content"? Maybe we should also add deserialize_content_as for that one event with a variable event type (IIRC it's in account data).

@zecakeh
Copy link
Contributor Author

zecakeh commented Jan 5, 2023

Ah right we still need deserialize_content or deserialize_content_as for that one event type.

@zecakeh
Copy link
Contributor Author

zecakeh commented Jan 5, 2023

I'm actually gonna close this. If we remove StateUnsignedFromParts, then we have to find another way for the fallback CustomStateEventContent type to get the event_type.

@zecakeh zecakeh closed this Jan 5, 2023
@zecakeh zecakeh deleted the zecakeh/remove-from-parts branch January 5, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants