New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the dehydrated devices endpoints #1605
Conversation
ac0aaaa
to
a1f36c3
Compare
This patch adds support for the endpoints used in [MSC3814]. One notable change to the MSC here is that the PUT endpoint uploads the device and one-time keys as well. [MSC3814]: https://github.com/uhoreg/matrix-doc/blob/shrivelled_sessions/proposals/3814-dehydrated-devices-with-ssss.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried to be as thorough as possible, given that not everything is properly specced.
crates/ruma-client-api/src/dehydrated_device/delete_dehydrated_device.rs
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,48 @@ | |||
//! `DELETE /_matrix/client/*/dehydrated_device/` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For context, unspecced as of now, but mentioned in https://github.com/matrix-org/matrix-spec-proposals/pull/3814/files#r1266444656.
crates/ruma-client-api/src/dehydrated_device/delete_dehydrated_device.rs
Show resolved
Hide resolved
crates/ruma-client-api/src/dehydrated_device/put_dehydrated_device.rs
Outdated
Show resolved
Hide resolved
crates/ruma-client-api/src/dehydrated_device/put_dehydrated_device.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Kévin Commaille <76261501+zecakeh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that last comment, this looks good to me.
This is fine by me. You have the power to merge this, right? |
Yes I do. I'll merge this soonish. |
This patch adds support for the endpoints used in MSC3814.
One notable change to the MSC here is that the PUT endpoint uploads the
device and one-time keys as well.
Preview Removed