Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the dehydrated devices endpoints #1605

Merged
merged 9 commits into from Aug 9, 2023
Merged

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Jul 18, 2023

This patch adds support for the endpoints used in MSC3814.

One notable change to the MSC here is that the PUT endpoint uploads the
device and one-time keys as well.


Preview Removed

This patch adds support for the endpoints used in [MSC3814].

One notable change to the MSC here is that the PUT endpoint uploads the
device and one-time keys as well.

[MSC3814]: https://github.com/uhoreg/matrix-doc/blob/shrivelled_sessions/proposals/3814-dehydrated-devices-with-ssss.md
@poljar poljar marked this pull request as ready for review July 28, 2023 14:35
Copy link
Contributor

@zecakeh zecakeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to be as thorough as possible, given that not everything is properly specced.

crates/ruma-client-api/src/dehydrated_device.rs Outdated Show resolved Hide resolved
@@ -0,0 +1,48 @@
//! `DELETE /_matrix/client/*/dehydrated_device/`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, unspecced as of now, but mentioned in https://github.com/matrix-org/matrix-spec-proposals/pull/3814/files#r1266444656.

crates/ruma-client-api/src/lib.rs Show resolved Hide resolved
@poljar poljar requested a review from zecakeh August 2, 2023 11:40
Copy link
Contributor

@zecakeh zecakeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that last comment, this looks good to me.

crates/ruma-client-api/src/lib.rs Show resolved Hide resolved
@zecakeh
Copy link
Contributor

zecakeh commented Aug 8, 2023

This is fine by me. You have the power to merge this, right?

@poljar
Copy link
Contributor Author

poljar commented Aug 8, 2023

Yes I do. I'll merge this soonish.

@poljar poljar merged commit 0a82459 into main Aug 9, 2023
21 checks passed
@jplatte jplatte deleted the poljar/msc3814 branch August 9, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants