Parse and emit attributes connected to the request/response defs in ruma_api macro #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Aug 13, 2020
ruma-api-macros/src/api.rs
Outdated
Comment on lines
440
to
441
| let attributes = | ||
| if let Ok(attrs) = input.call(Attribute::parse_outer) { attrs } else { vec![] }; |
There was a problem hiding this comment.
I think this kind of thing is usually done using peek rather than taking an alternative branch if parsing fails. I'm not sure what this code would do on unexpected input (i.e. tokens that are none of [attribute, request_ke]).
There was a problem hiding this comment.
This works let attributes = input.call(Attribute::parse_outer)?;
I was wondering about not advancing the "cursor" and stuff I originally did have peek, but the syn docs say to use .call for attributes but now it will fail when it's supposed to I think.
DevinR528
force-pushed
the
req/resp-attrs
branch
from
300c74e
to
93fce09
Compare
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.