client-api: use authentication for profile api for synapse #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since #407 will simplify this a lot, I'd like to wait for that to be merged to then make this change a lot simpler. |
I agree, but since it's a really easy change I submitted an MR anyway. |
|
That PR has been merged, can you update this one? 🙂 |
Needs to be build with feature `unstable-synapse-quirks` Fixes: ruma#380
jsparber
force-pushed
the
profile_api_synapse_quirks
branch
from
bb2f551
to
43df4b8
Compare
|
i'm not really sure if i need to guard both |
You do need to do that, otherwise the generated code is going to contain duplicate fields when Thanks for your work on this! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be build with feature
unstable-synapse-quirksFixes: #380