-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xtask: Add release commit creation to release #508
Conversation
Since it has an independent version, it can just be handled like a "regular" crate without an associated macro crate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First part of review (everything except release.rs
)
But according to the docs it shouldn't be tagged or released, right? |
Right. Probably should just be a special case. |
I'm done with the commits. Ready for review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good overall, thanks again for working on this!
This adds several step:
macros
crate manifest, if it exists.macros
crate.I changed quite a bit the organisation of the code. The main reason is that we now get all the data for the crates from the
cargo metadata
result, to avoid having to also parse all the manifests.The only remaining quirk is the
ruma-identifiers-validation
crate that won't work with this.edit(jplatte): resolves #452