Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space related event changes #585

Merged
merged 7 commits into from
May 20, 2021
Merged

Space related event changes #585

merged 7 commits into from
May 20, 2021

Conversation

MTRNord
Copy link
Contributor

@MTRNord MTRNord commented May 18, 2021 •
edited
Loading

This PR adds the required parts needed for matrix-org/matrix-spec-proposals#1772

TODOs:

The prop is called room_type in the m.room.create event because type is reserved in rust.

Also this PR will not cover the summary API synapse has for spaces. Therefor this only partially tackles #445

@MTRNord MTRNord mentioned this pull request May 18, 2021
Open
2 tasks
@johannescpk johannescpk mentioned this pull request May 19, 2021
Merged
@jplatte
Copy link
Member

jplatte commented May 19, 2021

Since none of this has made it into even the unstable spec, please add #[cfg(feature = "unstable-pre-spec")] to all new fields and types.

@MTRNord @jplatte
Fix missing dot at sentence of doc comment
7f1b8f2 
Co-authored-by: Jonas Platte <jplatte@users.noreply.github.com>
@MTRNord MTRNord changed the base branch from main to next May 20, 2021 08:33
@MTRNord
Merge pull request johannescpk/johannescpk/spaces
f324521 
events: Add Space ChildEvent and ParentEvent
@MTRNord MTRNord marked this pull request as ready for review May 20, 2021 08:44
@MTRNord MTRNord changed the title WIP: Space related event changes Space related event changes May 20, 2021
jplatte
jplatte reviewed May 20, 2021
View reviewed changes
crates/ruma-client-api/src/r0/room/create_room.rs Outdated Show resolved Hide resolved
crates/ruma-events/src/room/create.rs Outdated Show resolved Hide resolved
crates/ruma-events/src/room/create.rs Outdated Show resolved Hide resolved
crates/ruma-events/src/room/create.rs Outdated Show resolved Hide resolved
@jplatte jplatte merged commit d7e5922 into ruma:next May 20, 2021
@jplatte jplatte mentioned this pull request May 20, 2021
Closed
@MTRNord MTRNord mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MTRNord @jplatte @johannescpk