Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: 138 GitHub apps, Changed: 2 GitHubUser names, Resorted List #492

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

DarkCrypt
Copy link
Contributor

Added: 121 GitHub apps.
Changed: 1 GitHubUser name; "vector-im" -> "element-hq". See vector-im for reference.
Resorted List

Added: 121 GitHub apps
Changed: 1 GitHubUser name; "vector-im" -> "element-hq". See [Element](https://github.com/vector-im) for reference.
Resorted List
@TotallyAvailable
Copy link
Contributor

Arcticons is about to be moved - Arcticons-Team/Arcticons#1799

And given your addition of the whole set of SMT, https://github.com/FossifyOrg is about to be released if you feel like adding those as well.

@DarkCrypt DarkCrypt marked this pull request as draft December 26, 2023 07:18
@DarkCrypt
Copy link
Contributor Author

Thank you for the info.

I changed Arcticons to try to reflect this move so right now the package name could be wrong.

I added all 17 FossifyOrg apps. There are 6 package names that they still need to change in their repos. I also tried to reflect these upcoming changes.

Sounds like SMT may bomb soon, might be deleting these from the list sometime(?)

(Total apps = 282)

@DarkCrypt DarkCrypt changed the title Added: 121 GitHub apps, Changed: 1 GitHubUser name, Resorted List Added: 138 GitHub apps, Changed: 1 GitHubUser name, Resorted List Dec 26, 2023
@DarkCrypt DarkCrypt changed the title Added: 138 GitHub apps, Changed: 1 GitHubUser name, Resorted List Added: 138 GitHub apps, Changed: 2 GitHubUser names, Resorted List Dec 26, 2023
@DarkCrypt DarkCrypt marked this pull request as ready for review December 26, 2023 08:35
@TotallyAvailable
Copy link
Contributor

TotallyAvailable commented Dec 28, 2023

As all 4 versions are now Reproducible on F-Droid, the packageid is probably going to stay as 'com.donnnno.arcticons'.
Given that the 4 flavors are attached to 1 GitHub release I'm not sure if it's even going to work like this without additional regex filtering.

Assuming the filter can handle more than 1 set of contains/notcontains the other 3 flavors could also be included.

Just going by the existing keepass2android entry, as each file is clearly labeled this should work ? Assuming it does, the existing Arcticons entry needs a

, contains("normal")

as well.

GitHubApp("com.donnnno.arcticons.you", "Arcticons-Team", "Arcticons", contains("you")),
GitHubApp("com.donnnno.arcticons.light", "Arcticons-Team", "Arcticons", contains("black")),
GitHubApp("com.donnnno.arcticons.daynight", "Arcticons-Team", "Arcticons", contains("dayNight")),
GitHubApp("com.mirfatif.mylocation", "mirfatif", "MyLocation"),
GitHubApp("com.aistra.hail", "aistra0528", "Hail"),
GitHubApp("app.simple.peri", "Hamza417", "Peri"),

There are so many more I would add...given that most of them provide full/lite/foss/market/libre/armv7&v8 versions with the same package name that's obviously not on me to decide which version a user of APKUpdater is supposed to use.
Breaking installations or causing issues is not something I want to do.

If I come across more potential (single version) inclusions the next time I manually hunt for updates, I'll add them.

@rumboalla rumboalla merged commit eb2e7ef into rumboalla:3.x Dec 29, 2023
1 check passed
@rumboalla
Copy link
Owner

As all 4 versions are now Reproducible on F-Droid, the packageid is probably going to stay as 'com.donnnno.arcticons'. Given that the 4 flavors are attached to 1 GitHub release I'm not sure if it's even going to work like this without additional regex filtering.

Assuming the filter can handle more than 1 set of contains/notcontains the other 3 flavors could also be included.

Just going by the existing keepass2android entry, as each file is clearly labeled this should work ? Assuming it does, the existing Arcticons entry needs a

, contains("normal")

as well.

GitHubApp("com.donnnno.arcticons.you", "Arcticons-Team", "Arcticons", contains("you")),
GitHubApp("com.donnnno.arcticons.light", "Arcticons-Team", "Arcticons", contains("black")),
GitHubApp("com.donnnno.arcticons.daynight", "Arcticons-Team", "Arcticons", contains("dayNight")),

This should work as long as the package names are different.

GitHubApp("com.mirfatif.mylocation", "mirfatif", "MyLocation"),
GitHubApp("com.aistra.hail", "aistra0528", "Hail"),
GitHubApp("app.simple.peri", "Hamza417", "Peri"),

There are so many more I would add...given that most of them provide full/lite/foss/market/libre/armv7&v8 versions with the same package name that's obviously not on me to decide which version a user of APKUpdater is supposed to use. Breaking installations or causing issues is not something I want to do.

If I come across more potential (single version) inclusions the next time I manually hunt for updates, I'll add them.

If the file names are tagged with the architecture, the app will try to match it.

@DarkCrypt
Copy link
Contributor Author

@TotallyAvailable
Thank you for your help again!

I didn't consider other flavors when I was adding apps. I'll go back through the list and include any if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants