-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP Server for RPCs #62
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t function test passes.
…sts pass, performance is similar.
jlewitt1
reviewed
May 16, 2023
jlewitt1
reviewed
May 16, 2023
jlewitt1
reviewed
May 16, 2023
jlewitt1
reviewed
May 16, 2023
jlewitt1
reviewed
May 16, 2023
…ss, other than one detail with test_map.
…sts pass (except history).
…ster with json args and kwargs.
# Conflicts: # tests/test_function.py
@jlewitt1 @carolineechen this is just about ready to roll, thoughts and feedback would be super welcome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing!!
- Fix a bunch of test bugs
# Conflicts: # docs/api/cluster.rst
- Style. - Don't save ssh keys directly to config file. - Make logout only delete secrets added by login, not any enabled provider.
- Handle exceptions on RPC get_object better - Fix cancelling logic and tests - Fix system and package reload logic All fn tests pass.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the default server for sending RPCs between clusters from gRPC to HTTP.