Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Server for RPCs #62

Merged
merged 19 commits into from
May 19, 2023
Merged

HTTP Server for RPCs #62

merged 19 commits into from
May 19, 2023

Conversation

dongreenberg
Copy link
Contributor

This PR replaces the default server for sending RPCs between clusters from gRPC to HTTP.

@dongreenberg
Copy link
Contributor Author

@jlewitt1 @carolineechen this is just about ready to roll, thoughts and feedback would be super welcome!

Copy link
Collaborator

@carolineechen carolineechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!!

docs/debugging_logging.rst Outdated Show resolved Hide resolved
runhouse/rns/hardware/cluster.py Show resolved Hide resolved
runhouse/rns/hardware/cluster.py Outdated Show resolved Hide resolved
runhouse/rns/hardware/cluster.py Outdated Show resolved Hide resolved
runhouse/rns/hardware/cluster.py Outdated Show resolved Hide resolved
runhouse/rns/hardware/cluster.py Show resolved Hide resolved
tests/test_cluster.py Outdated Show resolved Hide resolved
tests/test_obj_store.py Outdated Show resolved Hide resolved
- Fix a bunch of test bugs
# Conflicts:
#	docs/api/cluster.rst
- Style.
- Don't save ssh keys directly to config file.
- Make logout only delete secrets added by login, not any enabled provider.
- Handle exceptions on RPC get_object better
- Fix cancelling logic and tests
- Fix system and package reload logic

All fn tests pass.
@dongreenberg dongreenberg merged commit 4155d1f into main May 19, 2023
3 of 4 checks passed
@dongreenberg dongreenberg deleted the http_server branch May 22, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants