Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multinode start now that we're passing env. #766

Merged
merged 1 commit into from
May 1, 2024

Conversation

rohinb2
Copy link
Contributor

@rohinb2 rohinb2 commented May 1, 2024

_start_ray_workers signature needs to match that of parent

Copy link

sentry-io bot commented May 1, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: runhouse/resources/hardware/on_demand_cluster.py

Function Unhandled Issue
_sky_status NameError: name 'sky' is not defined main in ...
Event Count: 2
_sky_status NameError: name 'sky' is not defined importlib._b...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link
Contributor Author

rohinb2 commented May 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on Graphite Graphite

@rohinb2 rohinb2 mentioned this pull request May 1, 2024
@rohinb2 rohinb2 merged commit d91e835 into main May 1, 2024
11 checks passed
@jlewitt1 jlewitt1 deleted the rohin/fix-multinode-start branch May 15, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant