Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect when deleted. #13611

Merged
merged 4 commits into from
May 22, 2024
Merged

Disconnect when deleted. #13611

merged 4 commits into from
May 22, 2024

Conversation

joshkyh
Copy link
Contributor

@joshkyh joshkyh commented May 21, 2024

Description

When building a RAG solution with Supabase, I often hit the max connection limit without this change even though I delete the agent instance and its tools. With this change, I no longer hit the max connection limit.

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

I used it in my existing proprietary code. Happy to write new tests if given instructions to connect to a supabase server.

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 21, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 22, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) May 22, 2024 01:02
@logan-markewich logan-markewich merged commit 34052ff into run-llama:main May 22, 2024
8 checks passed
Mateusz-Switala pushed a commit to Mateusz-Switala/llama_index that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants