Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try-catch in case the ._client attribute is not present #13681

Merged
merged 3 commits into from
May 24, 2024

Conversation

joshkyh
Copy link
Contributor

@joshkyh joshkyh commented May 23, 2024

Description

In my unit tests (outside of this repo), I found that sometimes the ._client attribute is not present, leading to failed tests when it calls the del function. This is a bugfix on #13611.

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

I ran my unit tests that uses llama_index outside of the repo.

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 23, 2024
Copy link
Contributor

@nerdai nerdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joshkyh!

Please kindly do the following:

  1. run make lint and make format, commit changes and push (our lint checks are failing)
  2. update the version number in llama-index-vector-stores-supabase/pyproject.toml

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 23, 2024
@nerdai
Copy link
Contributor

nerdai commented May 24, 2024

Thanks @joshkyh!

Please kindly do the following:

  1. run make lint and make format, commit changes and push (our lint checks are failing)
  2. update the version number in llama-index-vector-stores-supabase/pyproject.toml

@joshkyh -- no worries.... I took care of this. Thanks for the fix.

@nerdai nerdai enabled auto-merge (squash) May 24, 2024 14:21
@nerdai nerdai merged commit 2acb473 into run-llama:main May 24, 2024
8 checks passed
@joshkyh
Copy link
Contributor Author

joshkyh commented May 24, 2024

Thanks @nerdai, I was running the commands on my Windows wsl for an hour and it haven't completed. Appreciate the help!

Mateusz-Switala pushed a commit to Mateusz-Switala/llama_index that referenced this pull request Jun 13, 2024
)

* Try-catch in case the ._client attribute is not present

* lint

* vbump

---------

Co-authored-by: Andrei Fajardo <andrei@nerdai.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants