Broaden SQLAlchemy support in llama-index-vector-stores-postgres to 1.4+ #13936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
llama-index-vector-stores-postgres
currently has a dependency on SQLALchemy 2.0.However, there is a large body of existing code written for SQLAlchemy
1.4.x
, which is still maintained and in active use.This PR allows
llama-index-vector-stores-postgres
to be used with both versions, making is vastly easier to integrate into existing codebases. It also harmonises the repo withllama-index-core
which currently depends on1.4.49
.Added input validation for
schema_name
to allow safe usage of format string instead of an SQL param for schema creation.Type of Change
How Has This Been Tested?
pgvector/pgvector:pg14
docker container as back-end:1.4.49
and2.0.25
Suggested Checklist:
make format; make lint
to appease the lint gods