Fix text splitter by dealing with empty tokens #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveksilimkhan1
pushed a commit
to viveksilimkhan1/llama_index
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a text has a lot of empty spaces, e.g. "hello world", the separator splits the intermediate spaces into empty strings, which were counted as 0 when tokenized by itself. However when counted as part of the overall text e.g. "hello world", it would count as its own token (this example would have three tokens, not two tokens unlike "hello world").
Need to deal with this edge case. Hopefully this should resolve tokenization issues.
Closes #195