-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: repository cloning race condition (#2341) #2348
Conversation
The use of |
Tests failed because -.- |
I mean... upgrading to Go 1.18 doesn't seem to break anything, and it will happen at some point, right? |
I've replaced We should switch back to |
we are planning to update to go1.18 soon |
How soon though? This is slowing our whole engineering dept down massively. Plans that used to take 1-2min now take upwards for 40min. |
I'm fine raising the PR switching back to |
we can create a pre-release tomorrow and test on that image and next week
Friday we could have a base release.
We always need to make sure changes are tested by other members with
different workflows.
…On Thu., Jun. 30, 2022, 3:23 a.m. ribejara-te, ***@***.***> wrote:
I'm fine raising the PR switching back to sync for when Atlantis is
upgraded to go1.18, but it'd be great to have this fixed ASAP.
—
Reply to this email directly, view it on GitHub
<#2348 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQ3ERGOMPMEGNNVBCWYIS3VRVYS3ANCNFSM52FZVD5Q>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
@jamengual so do I revert the switch to semaphores? do you also want me to update go.mod to |
let's wait a few days to see if @chenrui333 is successful at upgrading to go1.18 and then we decide. |
What's the progress on that? Do we have an ETA on 1.18? @chenrui333 |
@jamengual doesn't look like go1.18 is going to happen in the next week- could we go ahead with this as is? |
in the world of open source and volunteering work, next week is like 1 days
in the pay to work outside the world :)
let's wait this week and if not we merge it.
…On Mon, Jul 11, 2022 at 5:57 PM skleiner-te ***@***.***> wrote:
@jamengual <https://github.com/jamengual> doesn't look like go1.18 is
going to happen in the next week- could we go ahead with this as is?
—
Reply to this email directly, view it on GitHub
<#2348 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQ3ERHY4WIF66ZVAMJWSBTVTS7INANCNFSM52FZVD5Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@jamengual can we proceed with the change? |
@chenrui333 what do you think? |
Hi, it's been 2 weeks since we agreed to waiting for 1 week before merging. Can we please merge? Again, once we upgrade to go1.18 it'll be as easy as |
Looking forward to getting this fixed. I have a repo with over 400 projects and enabling parallel would be great. |
fair, I think once we are ready we will move it update it. |
@ribejara-te we updated to 1.19 |
do you think you can create a PR with |
Sure |
You got it at #2521. |
…s#2348) * fix: repository cloning race condition (runatlantis#2341) * fix: switched from sync to golang.org/x/sync/semaphore * fix: check value of sem.Acquire(...)
This is my proposal to fix #2341.