Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update ghcr.io/runatlantis/testing-env docker tag to v2022.12.22 #2844

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 21, 2022

Mend Renovate

This PR contains the following updates:

Package Type Update Change
ghcr.io/runatlantis/testing-env container patch 2022.12.19 -> 2022.12.22
ghcr.io/runatlantis/testing-env docker patch 2022.12.19 -> 2022.12.22

Configuration

📅 Schedule: Branch creation - "every 1 hour after 00:00 and before 23:59" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner December 21, 2022 07:07
@renovate renovate bot added the dependencies PRs that update a dependency file label Dec 21, 2022
nitrocode
nitrocode previously approved these changes Dec 21, 2022
@nitrocode nitrocode dismissed their stale review December 21, 2022 14:22

failing test

@krrrr38
Copy link
Contributor

krrrr38 commented Dec 21, 2022

oh... e2e ensureRunningConftest check conftest command, but policy_check still require conftest$version command.

we can pass this test by adding e2e conftestVersion diff into this PR.

const ConftestVersion = "0.36.0" // renovate: datasource=github-releases depName=open-policy-agent/conftest


For future upgrade, we have some ideas.

  • Change renovate group settings
    • Create testing/Dockerfile conftest upgrade diff PR
    • Create testing-env and other conftest upgrade diff PR <- aggregate these
  • conftest use only one version?
    • use conftest instead conftest$version in policy check
  • download conftest$version automatically

@nitrocode
Copy link
Member

Let's just conftest instead conftest$version in policy check. I do not think the current test provides much value.

@renovate renovate bot changed the title chore(deps): update ghcr.io/runatlantis/testing-env docker tag to v2022.12.21 chore(deps): update ghcr.io/runatlantis/testing-env docker tag to v2022.12.22 Dec 22, 2022
@renovate renovate bot force-pushed the renovate/testing-env-ci-test branch from 2db2627 to 6bc21e1 Compare December 22, 2022 17:06
@nitrocode nitrocode merged commit 2c21358 into main Dec 22, 2022
@nitrocode nitrocode deleted the renovate/testing-env-ci-test branch December 22, 2022 17:30
@nitrocode nitrocode added this to the 0.22.0 milestone Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies PRs that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants